Make fetchdep check out matching branch name #29601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
on a push to a branch.
4 tasks
t3chguy
reviewed
Mar 27, 2025
Comment on lines
-85
to
-86
| elif [ -n "$BUILDKITE_PULL_REQUEST_BASE_BRANCH" ]; then | ||
| clone $deforg $defrepo $BUILDKITE_PULL_REQUEST_BASE_BRANCH |
There was a problem hiding this comment.
If we're dropping buildkite support here can we also drop it elsewhere, e.g. L48-L50
There was a problem hiding this comment.
Done, grep says that's everything.
t3chguy
reviewed
Mar 27, 2025
| # (ie. the 'master' branch should use matching 'master' dependencies) | ||
| base_or_branch=$GITHUB_BASE_REF | ||
| if [[ "$GITHUB_EVENT_NAME" == "push" ]]; then | ||
| base_or_branch=${GITHUB_REF} |
There was a problem hiding this comment.
isn't this what the block above is trying to do with TRY_BRANCH? This implies $head isn't set as expected
There was a problem hiding this comment.
Looks like $head is only set by getPRInfo() which is only run for PR builds, so I think that's all just for PRs.
t3chguy
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on a push to a branch.
We previously checked out develop js-sdk even when building / testing mster. This would have worked usually, except when we have non-backwards compat changes on the js-sdk which we sometimes do with unstable interfaces (like sliding sync).
Alternative to #29596
Checklist
public/exportedsymbols have accurate TSDoc documentation.