Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add setting to hide avatars of rooms you have been invited to. #29497

Merged
merged 7 commits into from
Mar 14, 2025
Merged

Add setting to hide avatars of rooms you have been invited to. #29497

merged 7 commits into from
Mar 14, 2025

Conversation

Half-Shot
Copy link
Member

@Half-Shot Half-Shot commented Mar 14, 2025 •
edited
Loading

Part of element-hq/element-meta#2780.

This works by checking your membership of the room, and refusing to load the avatar if the room membership is invite or not known (e.g. 3pid invites). This is currently backed by a setting.

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

@Half-Shot Half-Shot changed the title Add ability to block images of rooms you have been invited to. Add ability to block avatars of rooms you have been invited to. Mar 14, 2025
@Half-Shot Half-Shot changed the title Add ability to block avatars of rooms you have been invited to. Add setting to hide avatars of rooms you have been invited to. Mar 14, 2025
@Half-Shot Half-Shot marked this pull request as ready for review March 14, 2025 11:18
@Half-Shot Half-Shot requested review from a team as code owners March 14, 2025 11:18
MidhunSureshR
MidhunSureshR approved these changes Mar 14, 2025
View reviewed changes
Copy link
Member

@MidhunSureshR MidhunSureshR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@Half-Shot Half-Shot enabled auto-merge March 14, 2025 11:47
@Half-Shot Half-Shot added this pull request to the merge queue Mar 14, 2025
Merged via the queue into develop with commit 66d9d71 Mar 14, 2025
32 checks passed
@Half-Shot Half-Shot deleted the hs/hide-avatars-for-invites branch March 14, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MidhunSureshR MidhunSureshR MidhunSureshR approved these changes

@dbkr dbkr Awaiting requested review from dbkr dbkr is a code owner automatically assigned from element-hq/element-web-reviewers

@florianduros florianduros Awaiting requested review from florianduros florianduros is a code owner automatically assigned from element-hq/element-web-reviewers

Assignees
No one assigned
Labels
T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Half-Shot @MidhunSureshR