AccessSecretStorageDialog: fix inability to enter recovery key #30090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `onFinished` isn't used if `hasCancel` is false, it's a bit silly to make it mandatory.
richvdh
force-pushed
the
rav/fix_recovery_key_entry
branch
from
9ae0cbf to
337a375
Compare
richvdh
changed the title
AccessSecretStorageDialog in a BaseDialog. The main thing this achieves is a FocusLock.
t3chguy
approved these changes
Jun 6, 2025
Wrap AccessSecretStorageDialog in a `BaseDialog`. The main thing this achieves is a `FocusLock`.
We have two copies of the same code, and we're about to add a third...
richvdh
force-pushed
the
rav/fix_recovery_key_entry
branch
from
337a375 to
f712fcd
Compare
andybalaam
approved these changes
Jun 6, 2025
| > | ||
| {content} | ||
| </EncryptionCard> | ||
| <BaseDialog fixedWidth={false} hasCancel={false}> |
There was a problem hiding this comment.
I went back and forth about that fact that this dialog does have a cancel button, so shouldn't it use the one provided by BaseDialog, and why shouldn't it have an X in the top right, but I think your change strictly makes things better so is fine for now.
There was a problem hiding this comment.
Fair point. I just made it match the designs.
richvdh
force-pushed
the
rav/fix_recovery_key_entry
branch
from
167507f to
18b9c36
Compare
snowping
pushed a commit
to Novaloop-AG/element-web
that referenced
this pull request
Jun 22, 2025
…nt-hq#30090) * BaseDialog: fix documentation, and make `onFinished` optional Since `onFinished` isn't used if `hasCancel` is false, it's a bit silly to make it mandatory. * AccessSecretStorageDialog: fix inability to enter recovery key Wrap AccessSecretStorageDialog in a `BaseDialog`. The main thing this achieves is a `FocusLock`. * playwright: factor out helper for verification We have two copies of the same code, and we're about to add a third... * playwright: test for verifying from Settings * Add a unit test for BaseDialog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrap
AccessSecretStorageDialogin aBaseDialog. The main thing this achieves is aFocusLock.Also, some fixes to the documentation on BaseDialog, and a playwright test.
Review commit-by-commit.
Fixes: #30089