Settings: flip local video feed by default #29501
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most (if not all) video chat apps show my local video mirrored. Element not doing it by default is makes it confusing at first. Even my phone camera app does it. Not only matching other video chat tools out there, 99% of times you see yourself in your day to day life is through a mirror, which flips the image. So matching that makes the most sense, to preserve continuity. This setting was made optional in element-hq#5437 but not defaulted to true. Fixes https://github.com/element-hq/element-web/issues/10651
github-actions
bot
added
the
Z-Community-PR
|
There was some contention on this when it was introduced so this should probably be a product decision. That said, this will only be for legacy 1:1 calls anyway, and EC mirrors the local video feed with no option (although is smart enough to only do it for front-facing ones). |
|
|
|
Product have signed off on this. It's a tiny change, but we still need the CLA signoff, unfortunately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most (if not all) video chat apps show my local video mirrored. Element not doing it by default is makes it confusing at first. Even my phone camera app does it.
Not only matching other video chat tools out there, 99% of times you see yourself in your day to day life is through a mirror, which flips the image. So matching that makes the most sense, to preserve continuity.
This setting was made optional in #5437 but not defaulted to true.
Fixes element-hq/element-meta#2846
Checklist
public/exportedsymbols have accurate TSDoc documentation.