Fix battery drain from Web Audio #29203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Z-Community-PR
t3chguy
requested changes
Feb 6, 2025
|
I moved the initial suspend (apparently required by Firefox) away from the constructor. This fixes the tests locally. |
|
|
…to fork/mbachry/suspend
Signed-off-by: Michael Telatynski <[email protected]>
t3chguy
approved these changes
Apr 29, 2025
snowping
pushed a commit
to Novaloop-AG/element-web
that referenced
this pull request
Jun 22, 2025
* Fix battery drain from Web Audio * move suspend away from constructor * await on resume() * Delint Signed-off-by: Michael Telatynski <[email protected]> --------- Signed-off-by: Michael Telatynski <[email protected]> Co-authored-by: Michael Telatynski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Element audio notifications cause a small, but noticeable battery drain on my Linux laptop, both with Firefox and Chromium. The drain is constant and disappears only after closing Element tab or the browser. In Firefox merely launching Element starts the battery issues, in Chromium it happens after the first notification arrives.
Here's a screenshot from
pw-toplong after a notification happened:pw-cli infoconfirms the bogus stream is an Element tab.Web Audio doc says: "The suspend() method of the AudioContext Interface suspends the progression of time in the audio context, temporarily halting audio hardware access and reducing CPU/battery usage in the process — this is useful if you want an application to power down the audio hardware when it will not be using an audio context for a while."