-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Use the JoinRuleSettings component for the guest link access prompt. #28614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
57bf52a
to
821416d
Compare
The translations in german need to be moved to localizy!
Here are the values for reference |
cfd6833
to
3633dbc
Compare
3633dbc
to
2eb6b5d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise lgtm though
|
||
&.mx_StyledRadioButton_disabled + span { | ||
opacity: 0.5; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this from a design? In general I'd prefer things to just be actual colours rather than rely on opacity blending with the background.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not from design but a conscious decision. This way any styling inside the element (like the black title vs grey subtitle) will get adjusted accordingly.
This can not get prioritized for about two weeks. |
Any news on this? It's coming up in our oldest non-draft PRs in the chapter meeting every week. |
I can finally work on this now! |
Co-authored-by: fkwp <[email protected]>
4d9ff87
to
bf01a12
Compare
c4c64b8
to
b4d3c7c
Compare
b4d3c7c
to
6f9035a
Compare
…lement-hq#28614) * Use the JoinRuleSettings component for the guest link access prompt. Co-authored-by: fkwp <[email protected]> * increase timeout * fix tests --------- Co-authored-by: fkwp <[email protected]>
Checklist
public
/exported
symbols have accurate TSDoc documentation.