Skip to content

Use the JoinRuleSettings component for the guest link access prompt. #28614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 2, 2025

Conversation

toger5
Copy link
Contributor

@toger5 toger5 commented Dec 2, 2024

image

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

@toger5
Copy link
Contributor Author

toger5 commented Dec 2, 2024

The translations in german need to be moved to localizy!
They will be lost when merged,

        "description": "Um einen Konferenzlink zu erstellen, mache diesen Raum <b>öffentlich</b> oder aktiviere die Option, dass Benutzer eine <b>Beitrittsanfrage</b> stellen können. So können Gäste ohne direkte Einladung beitreten.",
        "dont_change_description": "Wenn die Zugriffsrechte dieses Raums unverändert bleiben sollen, erstelle einen neuen Raum für die Element-Call Videokonferenz.",
        "revert_access_description": "(In den Raum Einstellungen kann die Zutrittseinstellung zurückgesetzt werden: <b>Sicherheit</b> / <b>Zutritt</b>)",
        "no_change": "Ich möchte die Raum Zutrittseinstellung nicht ändern.",
        "title": "Erlaube Gastbenutzern, diesen Raum beizutreten"

Here are the values for reference

@CLAassistant
Copy link

CLAassistant commented Mar 21, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm though


&.mx_StyledRadioButton_disabled + span {
opacity: 0.5;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this from a design? In general I'd prefer things to just be actual colours rather than rely on opacity blending with the background.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not from design but a conscious decision. This way any styling inside the element (like the black title vs grey subtitle) will get adjusted accordingly.

@toger5
Copy link
Contributor Author

toger5 commented Mar 31, 2025

This can not get prioritized for about two weeks.
If it is undesired to have it open/merg-able for two weeks we can put it back into draft and I will reopen it and tackle the comments/test once we can make resources for it.

@dbkr
Copy link
Member

dbkr commented Apr 28, 2025

Any news on this? It's coming up in our oldest non-draft PRs in the chapter meeting every week.

@toger5
Copy link
Contributor Author

toger5 commented May 2, 2025

Any news on this? It's coming up in our oldest non-draft PRs in the chapter meeting every week.

I can finally work on this now!

@toger5 toger5 force-pushed the toger5/guest-link-room-access-prompt branch from b4d3c7c to 6f9035a Compare May 2, 2025 13:06
@toger5 toger5 added this pull request to the merge queue May 2, 2025
Merged via the queue into develop with commit 671e55c May 2, 2025
33 checks passed
@toger5 toger5 deleted the toger5/guest-link-room-access-prompt branch May 2, 2025 13:34
snowping pushed a commit to Novaloop-AG/element-web that referenced this pull request Jun 22, 2025
…lement-hq#28614)

* Use the JoinRuleSettings component for the guest link access prompt.

Co-authored-by: fkwp <[email protected]>

* increase timeout

* fix tests

---------

Co-authored-by: fkwp <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants