New room list: add selection decoration #29531

florianduros · 2025-03-18T14:48:39Z

This PR:

removes the 1px padding between the room list right border and the room list item. It's not necessary
adds a background colour when a room list item is selected
scrolls to the current room in the room list

Screen.Recording.2025-03-18.at.15.38.29.mov

…l list to this element

MidhunSureshR

Looks great!

florianduros added 2 commits March 18, 2025 15:45

fix(room list): remove 1px extra padding

ab17714

feat(room list): add selection decoration to room list item and scrol…

89cb9ec

…l list to this element

florianduros added the T-Enhancement label Mar 18, 2025

florianduros added 2 commits March 18, 2025 16:02

test(room list item): add is selected test

de1e27f

test(room list): update snapshot

a4ad45e

github-actions bot deployed to Netlify March 18, 2025 15:10 View deployment

github-actions bot deployed to EndToEndTests March 18, 2025 15:19 View deployment

florianduros added 2 commits March 18, 2025 16:54

test(e2e): add test to keep the room list item visible

1f9e0e0

test(e2e): update snapshots

049682d

github-actions bot deployed to Netlify March 18, 2025 16:03 View deployment

github-actions bot deployed to EndToEndTests March 18, 2025 16:13 View deployment

florianduros marked this pull request as ready for review March 18, 2025 16:21

florianduros requested a review from a team as a code owner March 18, 2025 16:21

florianduros requested review from dbkr and MidhunSureshR March 18, 2025 16:21

MidhunSureshR approved these changes Mar 18, 2025

View reviewed changes

florianduros added this pull request to the merge queue Mar 19, 2025

Merged via the queue into develop with commit 3587161 Mar 19, 2025
43 checks passed

florianduros deleted the florianduros/new-room-list/selected-tile branch March 19, 2025 08:51

Provide feedback