Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RoomListViewModel: Track the index of the active room in the list #29519

Merged
merged 4 commits into from
Mar 18, 2025
Merged

RoomListViewModel: Track the index of the active room in the list #29519

merged 4 commits into from
Mar 18, 2025

Conversation

MidhunSureshR
Copy link
Member

  • Provides hook useIndexForActiveRoom(rooms) that returns the index of the currently active room in the room list.
  • Uses this hook in the vm and exposes the result for the view to use.

@MidhunSureshR
Introduce a hook to track active room
b5d05d5 
This hook simply keeps a state which tracks the index of the active room
in the list of rooms passed through props. This index will be recomputed
if the active rooms changes or if the list itself changed.
@MidhunSureshR
Use hook in the view model
373463f
@MidhunSureshR
Write tests
5c7e03d
@MidhunSureshR MidhunSureshR force-pushed the midhun/rls/vm-active-room branch from 6b4ad91 to a4e85ae Compare March 18, 2025 11:28
@MidhunSureshR MidhunSureshR force-pushed the midhun/rls/vm-active-room branch from a4e85ae to 4adf887 Compare March 18, 2025 11:38
@MidhunSureshR MidhunSureshR marked this pull request as ready for review March 18, 2025 11:55
@MidhunSureshR MidhunSureshR requested a review from a team as a code owner March 18, 2025 11:55
@MidhunSureshR MidhunSureshR added this pull request to the merge queue Mar 18, 2025
Merged via the queue into develop with commit 839329b Mar 18, 2025
38 checks passed
@MidhunSureshR MidhunSureshR deleted the midhun/rls/vm-active-room branch March 18, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbkr dbkr dbkr approved these changes

@florianduros florianduros Awaiting requested review from florianduros florianduros is a code owner automatically assigned from element-hq/element-web-reviewers

Assignees
No one assigned
Labels
T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MidhunSureshR @dbkr