Global configuration flag for media previews #29582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
|
Looks fine to me but the spacing seems a bit off between:
|
How's this @amshakal ? |
|
That's better! :) TY! |
amshakal
approved these changes
Apr 17, 2025
t3chguy
requested changes
Apr 22, 2025
res/css/views/settings/tabs/user/_MediaPreviewAccountSettings.pcss
Outdated
Show resolved
Hide resolved
t3chguy
approved these changes
Apr 22, 2025
4 tasks
acheong08
pushed a commit
to acheong08/element-web
that referenced
this pull request
Apr 30, 2025
* Modify useMediaVisible to take a room. * Add initial support for a account data level key. * Update controls. * Update settings * Lint and fixes * make some tests go happy * lint * i18n * update preferences * prettier * Update settings tab. * update screenshot * Update docs * Rewrite controller * Rewrite tons of tests * Rewrite RoomAvatar to be a functional component This is so we can use hooks to determine the setting state. * lint * lint * Tidy up comments * Apply media visible hook to inline images. * Move conditionals. * copyright all the things * Review changes * Update html utils to properly discard media. * Types fix * Fixing tests that break settings getValue expectations * Fix logic around media preview calculation * Fix room header tests * Fixup tests for timelinePanel * Clear settings in matrixchat * Update tests to use SettingsStore where possible. * fix bug * revert changes to client.ts * copyright years * Add header * Add a test for MediaPreviewAccountSettingsTab * Mark initMatrixClient as optional * Improve on types * Ensure we do not set the account data twice. * lint * Review changes * Ensure we include the client on rendered messages. * Fix test * update labels * clean designs * update settings tab * update snapshot * copyright * prevent mutation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements MSC4155
Figma
This feature adds support for an account-level setting for configuring your own safety levels when browsing rooms. We already have support for configuring media previews on a per-device level but this allows the configuration to be expressed cross-device / client.
While not explicitly implemented, this also allows for servers to express defaults for their users (by setting default account data, if the server supports it).
Global setting
Room setting
Checklist
public/exportedsymbols have accurate TSDoc documentation.