New room list: add keyboard navigation support #29805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florianduros
force-pushed
the
florianduros/new-room-list/a11y-keyboard
branch
from
c9b8eeb to
94920e4
Compare
florianduros
force-pushed
the
florianduros/new-room-list/a11y-keyboard
branch
from
cf8056d to
0387c0f
Compare
florianduros
force-pushed
the
florianduros/new-room-list/a11y-keyboard
branch
from
0387c0f to
697fc8e
Compare
florianduros
force-pushed
the
florianduros/new-room-list/a11y-keyboard
branch
from
697fc8e to
3b9e8f2
Compare
florianduros
force-pushed
the
florianduros/new-room-list/a11y-keyboard
branch
from
3b9e8f2 to
56677d7
Compare
florianduros
force-pushed
the
florianduros/new-room-list/a11y-keyboard
branch
from
56677d7 to
59a349a
Compare
florianduros
force-pushed
the
florianduros/new-room-list/a11y-keyboard
branch
from
930e9b5 to
c925e40
Compare
florianduros
force-pushed
the
florianduros/new-room-list/a11y-keyboard
branch
from
c445a47 to
f2f9ac1
Compare
florianduros
force-pushed
the
florianduros/new-room-list/a11y-keyboard
branch
from
f2f9ac1 to
4e57094
Compare
florianduros
force-pushed
the
florianduros/new-room-list/a11y-keyboard
branch
from
4e57094 to
dc457f4
Compare
dbkr
approved these changes
May 6, 2025
| const vm = useRoomListItemViewModel(room); | ||
|
|
||
| const [isHover, setIsHover] = useState(false); | ||
| const [isHover, setIsHover] = useIsHover(); |
There was a problem hiding this comment.
Suggested change
| const [isHover, setIsHover] = useIsHover(); | |
| const [isHover, setIsHoverWithDelay] = useIsHover(); |
to match maybe?
parsatorb
pushed a commit
to iluvatar-tech/element-web
that referenced
this pull request
May 6, 2025
* feat: support up/down arrow navigation in the new room list * feat: support tabbing in the new room list * test: update snapshots * test(e2e): fix room list test * test(new room list): add landmark navigation test * test(e2e): update screenshot test * test: add test to `RoomListItemView` * test(e2e): add keyboard navigation tests * refactor: rename `setIsHover` on `setIsHoverWithDelay`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task https://github.com/element-hq/wat-internal/issues/204
This PR is a first step to add keyboard navigation to the new room list:
RovingTabIndexcomponentScreen.Recording.2025-05-06.at.11.44.26.mov
NB: The landmark shortcut support for the search bar of the left panel will be added in another PR.