New Room List: Prevent old tombstoned rooms from appearing in the list #29881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basically when someone changes their name, any old tombstoned rooms that were previously hidden would suddenly show up in the list.
- `reInsertRoom` that re-inserts a room that is already known by the skiplist. - `addNewRoom` to add new rooms The idea is that sometimes you only want to re-insert to noop, eg: when you get an event in an old room that was upgraded.
Only use `addNewRoom` when absolutely necessary. Most events should instead use `reInsertRoom` which will noop when the room isn't already known by the skiplist.
MidhunSureshR
force-pushed
the
midhun/rls/fix-old-rooms-in-list
branch
from
91d260f to
a2d84fb
Compare
MidhunSureshR
force-pushed
the
midhun/rls/fix-old-rooms-in-list
branch
from
0bf90cb to
69bfc6d
Compare
MidhunSureshR
force-pushed
the
midhun/rls/fix-old-rooms-in-list
branch
from
69bfc6d to
677ac5b
Compare
dbkr
approved these changes
May 6, 2025
parsatorb
pushed a commit
to iluvatar-tech/element-web
that referenced
this pull request
May 6, 2025
element-hq#29881) * Write failing playwright test Basically when someone changes their name, any old tombstoned rooms that were previously hidden would suddenly show up in the list. * Split addRoom into two methods - `reInsertRoom` that re-inserts a room that is already known by the skiplist. - `addNewRoom` to add new rooms The idea is that sometimes you only want to re-insert to noop, eg: when you get an event in an old room that was upgraded. * Use new methods in the RLS Only use `addNewRoom` when absolutely necessary. Most events should instead use `reInsertRoom` which will noop when the room isn't already known by the skiplist. * Fix broken tests * Add new test * Fix playwright test
snowping
pushed a commit
to Novaloop-AG/element-web
that referenced
this pull request
Jun 22, 2025
element-hq#29881) * Write failing playwright test Basically when someone changes their name, any old tombstoned rooms that were previously hidden would suddenly show up in the list. * Split addRoom into two methods - `reInsertRoom` that re-inserts a room that is already known by the skiplist. - `addNewRoom` to add new rooms The idea is that sometimes you only want to re-insert to noop, eg: when you get an event in an old room that was upgraded. * Use new methods in the RLS Only use `addNewRoom` when absolutely necessary. Most events should instead use `reInsertRoom` which will noop when the room isn't already known by the skiplist. * Fix broken tests * Add new test * Fix playwright test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When somebody changes their display name,
m.room.memberstate event and read receipts are sent to all rooms including tombstoned or upgraded rooms. Previously, the RLS would add the room associated with such events into the skiplist regardless of whether they should be shown in the list or not. This would sometime cause old upgraded rooms to show in the list.This PR prevents such rooms from being added into the skip list:
addRoommethod.reInsertRoommethod which will only insert the room if the room is already in the skiplist. This is the method that will be used most frequently.addNewRoommethod that adds new rooms that are not in the skiplist. This method will throw an error if the room is already in the skiplist.