New room list: move secondary filters into primary filters #29972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florianduros
force-pushed
the
florianduros/new-room-list/merge-filters
branch
from
6f8464d to
e64358f
Compare
florianduros
force-pushed
the
florianduros/new-room-list/merge-filters
branch
from
bdf32c9 to
4f58ab3
Compare
florianduros
force-pushed
the
florianduros/new-room-list/merge-filters
branch
from
4f58ab3 to
c8dd9f2
Compare
florianduros
force-pushed
the
florianduros/new-room-list/merge-filters
branch
from
94abbcd to
dfe221e
Compare
florianduros
force-pushed
the
florianduros/new-room-list/merge-filters
branch
from
dfe221e to
13c081e
Compare
florianduros
force-pushed
the
florianduros/new-room-list/merge-filters
branch
from
13c081e to
f923f54
Compare
florianduros
force-pushed
the
florianduros/new-room-list/merge-filters
branch
from
f923f54 to
58aaa51
Compare
florianduros
commented
May 20, 2025
There was a problem hiding this comment.
The cell height should be 48px. I wonder why the screenshot height was 49px since the cell is untouched in this PR (and its 48px on develop).
I suspect a playwright shenanigan
There was a problem hiding this comment.
I guess fractional pixel shifts again
dbkr
reviewed
May 20, 2025
There was a problem hiding this comment.
I guess fractional pixel shifts again
dbkr
approved these changes
May 20, 2025
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Jun 4, 2025
https://build.opensuse.org/request/show/1282724 by user dheidler + dimstar_suse - Version 1.11.102 ## ✨ Features * EW: Modernize the recovery key input modal (element-hq/element-web#29819). Contributed by @uhoreg. * New room list: move secondary filters into primary filters (element-hq/element-web#29972). Contributed by @florianduros. * Prompt the user when key storage is unexpectedly off (element-hq/element-web#29912). Contributed by @andybalaam. * New room list: move sort menu in room list header (element-hq/element-web#29983). Contributed by @florianduros. * New room list: rework spacing of room list item (element-hq/element-web#29965). Contributed by @florianduros. * RLS: Remove forgotten room from skiplist (https://github.com/elemen
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Jun 4, 2025
https://build.opensuse.org/request/show/1282787 by user dheidler + dimstar_suse - Version 1.11.102 ## ✨ Features * Support build-time specified protocol scheme for oidc callback (element-hq/element-desktop#2285). Contributed by @t3chguy. * EW: Modernize the recovery key input modal (element-hq/element-web#29819). Contributed by @uhoreg. * New room list: move secondary filters into primary filters (element-hq/element-web#29972). Contributed by @florianduros. * Prompt the user when key storage is unexpectedly off (element-hq/element-web#29912). Contributed by @andybalaam. * New room list: move sort menu in room list header (element-hq/element-web#29983). Contributed by @florianduros. * New room list: rework spacing of room list item (https
snowping
pushed a commit
to Novaloop-AG/element-web
that referenced
this pull request
Jun 22, 2025
…q#29972) * feat: move secondary filters into primary filters in vm * test: update room list view model tests * feat: remove secondary filter menu * test: update and remove secondary filter component tests * feat: update i18n * test: update remaining tests * test(e2e): update screenshots and tests * feat: add new cases for empty room list * test(e2e): add more tests for empty room list for new primary filters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task https://github.com/element-hq/wat-internal/issues/204
Figma
This PR moves the mention and invitation secondary filters into the primary filters. The secondary filter menu is removed.
In an incoming PR, the primary filter list will be collapsible (see Figma).