New room list: rework spacing of room list item #29965
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florianduros
force-pushed
the
florianduros/new-room-list/spacing-rework
branch
from
89fd488 to
f955341
Compare
|
check how it looks on half of the screen and on small screens please |
florianduros
force-pushed
the
florianduros/new-room-list/spacing-rework
branch
from
f955341 to
b6a899a
Compare
florianduros
force-pushed
the
florianduros/new-room-list/spacing-rework
branch
from
b6a899a to
30564d7
Compare
|
@dzienisz An example on a small screen:
|
dbkr
approved these changes
May 16, 2025
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Jun 4, 2025
https://build.opensuse.org/request/show/1282724 by user dheidler + dimstar_suse - Version 1.11.102 ## ✨ Features * EW: Modernize the recovery key input modal (element-hq/element-web#29819). Contributed by @uhoreg. * New room list: move secondary filters into primary filters (element-hq/element-web#29972). Contributed by @florianduros. * Prompt the user when key storage is unexpectedly off (element-hq/element-web#29912). Contributed by @andybalaam. * New room list: move sort menu in room list header (element-hq/element-web#29983). Contributed by @florianduros. * New room list: rework spacing of room list item (element-hq/element-web#29965). Contributed by @florianduros. * RLS: Remove forgotten room from skiplist (https://github.com/elemen
snowping
pushed a commit
to Novaloop-AG/element-web
that referenced
this pull request
Jun 22, 2025
* feat: rework spacing of room list item * test: update snapshot * test(e2e): regenerate room list panel screenshots * test(e2e): regenerate room list screenshots * test(e2e): update filter screenshot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task https://github.com/element-hq/wat-internal/issues/204
Figma
This PR aims to improve visually the spacing of the room list item. The goal is to align the icons and elements like:
Figma screenshot
The secondary filters and sort section will move in incoming PRs so we don't bother to change it's spacing.
Changes
The notification and three dots are compound icon buttons and don't have the same size than the notification icons. These buttons has a size of 24px an expected 20px icon in it (icon is 18px in the implementation due to element-hq/compound-web#331) so we need to have a different spacing.
