-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New room list: move sort menu in room list header #29983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
florianduros
merged 6 commits into
develop
from
florianduros/new-room-list/move-sort-menu
May 19, 2025
Merged
New room list: move sort menu in room list header #29983
florianduros
merged 6 commits into
develop
from
florianduros/new-room-list/move-sort-menu
May 19, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florianduros
commented
May 19, 2025
@@ -59,7 +55,7 @@ describe("RoomListViewModel", () => { | |||
|
|||
const newRoom = mkStubRoom("bar:matrix.org", "Bar", undefined); | |||
rooms.push(newRoom); | |||
act(() => RoomListStoreV3.instance.emit(LISTS_UPDATE_EVENT)); | |||
await act(() => RoomListStoreV3.instance.emit(LISTS_UPDATE_EVENT)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing await
ecadf88
to
b26f11b
Compare
t3chguy
approved these changes
May 19, 2025
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Jun 4, 2025
https://build.opensuse.org/request/show/1282724 by user dheidler + dimstar_suse - Version 1.11.102 ## ✨ Features * EW: Modernize the recovery key input modal (element-hq/element-web#29819). Contributed by @uhoreg. * New room list: move secondary filters into primary filters (element-hq/element-web#29972). Contributed by @florianduros. * Prompt the user when key storage is unexpectedly off (element-hq/element-web#29912). Contributed by @andybalaam. * New room list: move sort menu in room list header (element-hq/element-web#29983). Contributed by @florianduros. * New room list: rework spacing of room list item (element-hq/element-web#29965). Contributed by @florianduros. * RLS: Remove forgotten room from skiplist (https://github.com/elemen
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Jun 4, 2025
https://build.opensuse.org/request/show/1282787 by user dheidler + dimstar_suse - Version 1.11.102 ## ✨ Features * Support build-time specified protocol scheme for oidc callback (element-hq/element-desktop#2285). Contributed by @t3chguy. * EW: Modernize the recovery key input modal (element-hq/element-web#29819). Contributed by @uhoreg. * New room list: move secondary filters into primary filters (element-hq/element-web#29972). Contributed by @florianduros. * Prompt the user when key storage is unexpectedly off (element-hq/element-web#29912). Contributed by @andybalaam. * New room list: move sort menu in room list header (element-hq/element-web#29983). Contributed by @florianduros. * New room list: rework spacing of room list item (https
snowping
pushed a commit
to Novaloop-AG/element-web
that referenced
this pull request
Jun 22, 2025
* feat: move sort and preview into room list header vm * feat: move sort menu into room list header * test: update tests * test:update snapshots * chore: remove secondary filter tests * test(e2e): update screenshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task https://github.com/element-hq/wat-internal/issues/204
Figma
This PR moves the sorting menu in the room list header and changes its icon.