In force-verify mode, prevent bypassing by cancelling device verification #29487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andybalaam
force-pushed
the
andybalaam/force-verify-even-if-cancel-device
branch
from
1e84825 to
1bc6117
Compare
andybalaam
force-pushed
the
andybalaam/force-verify-even-if-cancel-device
branch
from
1bc6117 to
6ef1c3b
Compare
andybalaam
force-pushed
the
andybalaam/force-verify-even-if-cancel-device
branch
from
6ef1c3b to
b317a5f
Compare
andybalaam
force-pushed
the
andybalaam/force-verify-even-if-cancel-device
branch
from
b317a5f to
ad26b1d
Compare
andybalaam
force-pushed
the
andybalaam/force-verify-even-if-cancel-device
branch
from
ad26b1d to
8b7cb62
Compare
florianduros
approved these changes
Mar 14, 2025
Adding tests was a struggle - would appreciate you taking a look at what I did to fix it in 138cf57 |
|
To give more context: it seems that there was a race between displaying the "Verify this device" screen ( |
|
FWIW I tried it all out manually after my latest changes and it still seems to work as it did before. |
florianduros
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29230
New behaviour: in force-verify mode, don't open the main app UI when we launch or close the "Verify with another device" dialog:
force-verify-device.mp4