RoomListStore: Remove invite rooms on decline #29804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
MidhunSureshR
commented
Apr 24, 2025
•
MidhunSureshR
commented
- Invites should be removed from the list when they're declined.
- Kicked rooms should remain in the list until they're explicitly forgotten.
It doesn't really matter what the previous membership was.
t3chguy
reviewed
Apr 24, 2025
| @@ -194,7 +194,7 @@ export class RoomListStoreV3Class extends AsyncStoreWithClient<EmptyObject> { | |||
| case "MatrixActions.Room.myMembership": { | |||
| const oldMembership = getEffectiveMembership(payload.oldMembership); | |||
| const newMembership = getEffectiveMembershipTag(payload.room, payload.membership); | |||
| if (oldMembership === EffectiveMembership.Join && newMembership === EffectiveMembership.Leave) { | |||
| if (newMembership === EffectiveMembership.Leave) { | |||
There was a problem hiding this comment.
I'm not sure this is right, if you get kicked from a room it should remain in your room list until it is forgotten otherwise you don't know you got kicked
|
See comment on 8aea39b#r155818724 |
t3chguy
approved these changes
Apr 24, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.