New room list: fix incorrect decoration #29770
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t3chguy
reviewed
Apr 15, 2025
There was a problem hiding this comment.
While you're in the area: useDMPresence doesn't seem to work quite right, getDMUser is not stable and can change, so should react to changes to m.direct - maybe use useDmMember?
There was a problem hiding this comment.
Thanks, I used useDmMember instead
There was a problem hiding this comment.
Looks like WithPresenceIndicator also has a usePresence which could likely replace the majority of the rest of the below hook
florianduros
force-pushed
the
florianduros/new-room-list/fix-icon-rerender
branch
from
28133ef to
901bf37
Compare
acheong08
pushed a commit
to acheong08/element-web
that referenced
this pull request
Apr 30, 2025
* fix(call): reset call value when the roomId changes * fix(call): reset presence indicator when the room changes * refactor: use existing `usePresence` * test: fix room avatar view test * test: update snapshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task https://github.com/element-hq/wat-internal/issues/204
When changing the filters, the decorations weren't recomputed and an incorrect decoration can appears on the wrong room.