Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Forgot recovery key? button to encryption tab #29202

Merged
merged 4 commits into from
Feb 6, 2025

Conversation

florianduros
Copy link
Member

@florianduros florianduros commented Feb 5, 2025

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

Figma design

Add a Forgot Recovery key? button to the encryption tab when the key storage is out of sync. Clicking on it displays the reset identity flow.

Screen.Recording.2025-02-06.at.09.43.53.mov

app,
util,
}) => {
await verifySession(app, "new passphrase");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW I fixed the bug where the actual recovery key didn't work here, so you can use that if you wish rather than hardcoding the passphrase that the bot client uses.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, thanks that's good news. I'll use it then

Copy link
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@florianduros florianduros added this pull request to the merge queue Feb 6, 2025
Merged via the queue into develop with commit 53f8312 Feb 6, 2025
51 checks passed
@florianduros florianduros deleted the florianduros/forgot-recovery-key-settings branch February 6, 2025 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants