-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Fix Docker Healthcheck #29471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Docker Healthcheck #29471
Conversation
I would appreciate if this could be hotfixed in a new release because currently loadbalancers may refuse to route traffic to the container as the healthcheck is failing... Totally didn't happen to me and I'm totally not going to disable the healthcheck for now :D |
A hotfix new release would be appreciated indeed! :) |
Temporary solution if using compose: healthcheck:
test: ["CMD", "sh", "-c", "wget -q -O- http://localhost:80/config.json"]
start_period: 5s
interval: 30s
retries: 3
timeout: 5s You may need to amend the port. Surprised no hotfix is out? (yet?) |
Now that element-hq/element-web#29471 is part of v1.11.96, we don't need to carry around this custom workaround.
Checklist
public
/exported
symbols have accurate TSDoc documentation.Fixes up the healthcheck added in #29351.
The
wget
in container is provided bybusybox
and only provides the following options:The test didn't catch this as
State.Running
istrue
even if the healthcheck is failing, e.g:Fixes #29472