Prompt users to set up recovery #30075
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uhoreg
added
the
T-Feature
uhoreg
added
T-Enhancement
and removed
T-Feature
uhoreg
force-pushed
the
prompt_set_up_recovery
branch
from
ee85cf0 to
4f25500
Compare
uhoreg
force-pushed
the
prompt_set_up_recovery
branch
from
48aff5f to
d6995d1
Compare
andybalaam
approved these changes
Jun 16, 2025
src/DeviceListener.ts
Outdated
| /** | ||
| * Account data key to indicate that the user has chosen to disable recovery. | ||
| */ | ||
| export const RECOVERY_DISABLED_ACCOUNT_DATA_KEY = "io.element.recovery_disabled"; |
There was a problem hiding this comment.
Note that MSC4287 proposes reversing the sense of the BACKUP_DISABLED boolean, so you might want to follow that pattern here.
There was a problem hiding this comment.
I've switched the sense of the boolean. Since it's a non-trivial change, can you give the PR another look?
t3chguy
requested changes
Jun 16, 2025
src/hooks/useEventEmitter.ts
Outdated
| * @returns State | ||
| */ | ||
| export function useEventEmitterAsyncState<T>( | ||
| emitter: EventEmitter | undefined, |
There was a problem hiding this comment.
Can we please avoid untyped EventEmitters? We prefer TypedEventEmitter all over the shop
t3chguy
approved these changes
Jun 16, 2025
andybalaam
approved these changes
Jun 18, 2025
| // We mark recovery as not disabled, in case it was | ||
| // marked as disabled before. | ||
| await matrixClient.setAccountData(RECOVERY_DISABLED_ACCOUNT_DATA_KEY, { disabled: false }); | ||
| // We mark recovery as not enabled. |
There was a problem hiding this comment.
That should be "We mark recovery as enabled" and I would probably rewrite it as "Record the fact that the user explicitly enabled recovery" or similar.
Merged
via the queue into
element-hq:develop
with commit Jun 18, 2025
af984c0
37 of 39 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #29232
Adds an indicator in the user settings dialog when the user doesn't have recovery set up
Update recovery setup toast with new button text, as per design, and remember if the user dismisses it.
It's easiest to review commit-by-commit.