Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker: allow configuration of HTTP listen port via env var #28840

Merged
merged 3 commits into from
Jan 3, 2025

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Jan 2, 2025

Notes: The HTTP listen port for the Docker image can now be configured via an environment variable.

Part of a solution to #25926

@richvdh richvdh requested a review from a team as a code owner January 2, 2025 13:53
@richvdh richvdh requested a review from dbkr January 2, 2025 13:53
@richvdh richvdh added the T-Feature Request to add a new feature which does not exist right now label Jan 2, 2025
@richvdh richvdh force-pushed the rav/docker/configurable_port branch from 3187ce1 to 4825916 Compare January 2, 2025 13:53
@richvdh richvdh added T-Enhancement and removed T-Feature Request to add a new feature which does not exist right now labels Jan 2, 2025
Co-authored-by: Michael Telatynski <[email protected]>
@richvdh richvdh added this pull request to the merge queue Jan 3, 2025
Merged via the queue into develop with commit 703149d Jan 3, 2025
33 checks passed
@richvdh richvdh deleted the rav/docker/configurable_port branch January 3, 2025 12:02
TommyTran732 added a commit to Polarix-Containers/element-web that referenced this pull request Jan 3, 2025
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Jan 15, 2025
https://build.opensuse.org/request/show/1238072
by user dheidler + anag+factory
- Version 1.11.90
  ## ✨ Features
  * Docker: run as non-root (element-hq/element-web#28849). Contributed by @richvdh.
  * Docker: allow configuration of HTTP listen port via env var (element-hq/element-web#28840). Contributed by @richvdh.
  * Update matrix-wysiwyg to consume WASM asset (element-hq/element-web#28838). Contributed by @t3chguy.
  * OIDC settings tweaks (element-hq/element-web#28787). Contributed by @t3chguy.
  * Delabs native OIDC support (element-hq/element-web#28615). Contributed by @t3chguy.
  * Move room header info button to right-most position (element-hq/element-web#28754). Contributed by @t3chguy.
  * Enable key backup by defa
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Jan 15, 2025
https://build.opensuse.org/request/show/1238071
by user dheidler + anag+factory
- Version 1.11.90
  ## ✨ Features
  * Docker: run as non-root (element-hq/element-web#28849). Contributed by @richvdh.
  * Docker: allow configuration of HTTP listen port via env var (element-hq/element-web#28840). Contributed by @richvdh.
  * Update matrix-wysiwyg to consume WASM asset (element-hq/element-web#28838). Contributed by @t3chguy.
  * OIDC settings tweaks (element-hq/element-web#28787). Contributed by @t3chguy.
  * Delabs native OIDC support (element-hq/element-web#28615). Contributed by @t3chguy.
  * Move room header info button to right-most position (element-hq/element-web#28754). Contributed by @t3chguy.
  * Enable key backup by defa
spantaleev added a commit to spantaleev/matrix-docker-ansible-deploy that referenced this pull request Mar 11, 2025
…nfig

Newer Element Web versions allow for the nginx port to be
overriden, etc., and provide instructions for running in read-only mode.

This makes our custom `nginx.conf` patches unnecessary.

Passing the correct `ELEMENT_WEB_PORT` environment variable
also helps with future changes.

Another benefit of this (besides keeping closer to upstream
recommendations and the improved simplicity) is that:

- the container can run its entrypoint env-substitutions code now,
  without reporting errors

- IPv6 for nginx works, so `matrix-client-element:8080` is accessible
  via IPv6 on the container network now
  (this affects only for Traefik's communicaton with Element Web
  internally; public connectivity was handled by Traefik and IPv6 was
  available there even before)

Ref:

- https://github.com/element-hq/element-web/blob/2052080d7d8a213064910cac491ec5cf9057610e/docs/install.md#docker
- element-hq/element-web#28849
- element-hq/element-web#28840
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants