Skip to content

Stop migrating to MSC4278 if the config exists. #29924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
May 12, 2025
Merged

Stop migrating to MSC4278 if the config exists. #29924

merged 14 commits into from
May 12, 2025

Conversation

Half-Shot
Copy link
Member

@Half-Shot Half-Shot commented May 12, 2025 •
edited
Loading

Suspected cause of #29923.

Tests coming soon TM

Checklist

  • Tests written for new code (and old code if feasible).
  • [N/A] New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • [N/A] I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

@Half-Shot Half-Shot requested a review from a team as a code owner May 12, 2025 07:54
@Half-Shot Half-Shot requested review from dbkr and t3chguy May 12, 2025 07:54
@Half-Shot Half-Shot changed the title Stop migrationg to MSC4278 if the config exists. Stop migrating to MSC4278 if the config exists. May 12, 2025
t3chguy
t3chguy reviewed May 12, 2025
View reviewed changes
@Half-Shot Half-Shot requested a review from t3chguy May 12, 2025 10:46
t3chguy
t3chguy reviewed May 12, 2025
View reviewed changes
@Half-Shot Half-Shot requested review from t3chguy and removed request for dbkr May 12, 2025 10:55
@Half-Shot Half-Shot enabled auto-merge May 12, 2025 11:01
t3chguy
t3chguy requested changes May 12, 2025
View reviewed changes
@Half-Shot Half-Shot requested a review from t3chguy May 12, 2025 11:03
@Half-Shot Half-Shot added this pull request to the merge queue May 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 12, 2025
@Half-Shot Half-Shot added this pull request to the merge queue May 12, 2025
Merged via the queue into develop with commit fb5c4ff May 12, 2025
35 checks passed
@Half-Shot Half-Shot deleted the hs/fix-remigration-of-mscsettings branch May 12, 2025 12:31
@Half-Shot Half-Shot mentioned this pull request Jun 12, 2025
Open
snowping pushed a commit to Novaloop-AG/element-web that referenced this pull request Jun 22, 2025
@Half-Shot @snowping
Stop migrating to MSC4278 if the config exists. (element-hq#29924)
dca8077 
* Stop migrationg to MSC4278 if the config exists.

* Run migration after we have synced the client.

* Setup the SettingsController with a client.

* Add tests to check migration behaviour.

* update copyright

* Wait for sync properly

* Catch failure

* Docs

* licence

* Inline async code

* Fix migrateURLPreviewsE2EE too

* drop an import

* go away
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t3chguy t3chguy t3chguy approved these changes

Assignees
No one assigned
Labels
T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Half-Shot @t3chguy