Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make themed widgets reflect the effective theme #28342

Merged
merged 3 commits into from
Jan 28, 2025

Conversation

robintown
Copy link
Member

@robintown robintown commented Oct 30, 2024

So that widgets such as Element Call will show up in the right theme even if the app is set to match the system theme.

Closes #27671
Depends on matrix-org/matrix-widget-api#117

@robintown robintown requested a review from a team as a code owner October 30, 2024 16:10
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this is the right solution given that system theme often changes based on time (day/night), and widgets have no way to receive a theme change. Maybe a widget should just make its own media queries if there is no provided theme to match system theme and that way it can respond to theme changes.

@robintown
Copy link
Member Author

Apologies for the force pushes. This is ready for another review but blocked on a related matrix-widget-api change.

So that widgets such as Element Call will show up in the right theme even if the app is set to match the system theme.
@hughns
Copy link
Member

hughns commented Jan 9, 2025

I'm not sure this is the right solution given that system theme often changes based on time (day/night), and widgets have no way to receive a theme change. Maybe a widget should just make its own media queries if there is no provided theme to match system theme and that way it can respond to theme changes.

@robintown have these concerns been addressed?

@robintown
Copy link
Member Author

robintown commented Jan 10, 2025

Yes, they have. I'm now updating the theme dynamically with a widget action.

@robintown robintown added this pull request to the merge queue Jan 28, 2025
Merged via the queue into element-hq:develop with commit c453d33 Jan 28, 2025
28 checks passed
@robintown robintown deleted the widget-effective-theme branch January 28, 2025 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calls use the wrong theme
4 participants