Deploy Checklist: New Expensify 2025-05-13

[github-actions]

Release Version: 9.1.45-18
Compare Changes: production...staging

This release contains changes from the following pull requests:

• fix: Content before dot separator is empty #60192
• Fix - Add Custom field 1 and Custom field 2 in the workspace member profile. #60277
• Stop creating the transaction thread reports optimistically for RequestMoney #60292
• [NoQA] Add CSpell for spelling checks [Part 3] #60399
• Update onboarding page with new integration choices #60505
• [Merge Account] Remove the initial route from state after successful merge #60751
• fix: autogrow heigh for TextInput #60842
• Magic code for secondary email is sent twice #60935
• fix: don't show Pay button to non-admin approvers #60939
• refactor: useSidebarOrderedReportIDs #60945
• Improve bottom tab switching by hiding PopoverMenu #60959
• ensure onboardingValues is not undefined when calling getOnboardingInitialPath #61021
• fix: get rid of Onyx console errors on login screen #61047
• [No QA] Create Delete-Expenses.md #61091
• [No QA] Create Getting-Started-with-the-Reports-Page.md #61128
• [No QA] Update Expensify-Card-Reconciliation.md #61132
• fix: reduced unnecessary API calls on workspace features #61169
• fix: In Add bank account confirmation page, tapping top arrow and device back button shows different navigation. #61270
• Generate the help content map file on the fly #61279
• Fix concierge chat is opens twice when deep link while logged out #61356
• fix: amount in report header does not match invoice amount when edit offline #61361
• fix: ComposeBox - When you click on the mention again, extra characters appear. #61362
• perf: calculate chat tab brick road based on derived value #61376
• Fix: Extra space between Save button and device navigation bar #61382
• Add grouping to RHP Filters #61432
• Fix extra space when using header markdown in money request description #61439
• Fix crash when trying to replace receipt #61471
• Fix: Offline indicator has extra spaces on the avatar modal #61481
• fix - Console error: BackHandler is not supported on web and should not be used #61487
• fix: get rid of redundant /Search API calls when opening report in RHN #61499
• Filter status suggestions based on selected type #61508
• update all references of workspace chat to expense chat #61529
• fix gbr on concierge chat even though no action required #61530
• Fix alerts when opening context menu from LHN #61542
• fix: RHN modal is dismissed after user unapproves an expense #61543
• move scroll to onLayout #61547
• fix: Expense Report Identification Footer Displaying Incorrectly #61551
• Let's chat CTA on BBA setup should link to our specific documentation asks #61665
• Add several UI fixes to MoneyRequestTransaction list #61677
• LHN Still Too Wide on Desktop After LHB Addition – Propose Reducing Width to 320px  #61678
• Fix keyboard doesn't show when input is refocused after status emoji picker is closed #61691
• fix skip tooltip rendering when element is not focused #61708
• Don't show WS page when deleted while offline #61710
• Fix icon type #61738
• Fix room doesn't show in search result #61749
• Create report simplified actions follow ups #61760
• fix: 60931 session storage clear on logout #61762
• fix: Receipt Loading Spinners on Reports Page Are Too Large #61764
• fix: search bar UI and selection mode followup #61765
• Fix React key and ref console errors in Report Debug Page #61776
• Revert "fix: an empty report state shows briefly when opening transaction thread in Reports" #61778
• [No QA] Fix Conditional Logic in publish.gradle patch and publishReactNativeAndroidArtifacts.yml #61779
• Background screen is changed to report screen on page refresh #61780
• [NoQA] Fix search navigator performance #61781
• Add canBeMissing onyx param explanation #61792
• [No QA] Update expert contributor onboarding template #61797
• Hide buttons instead of disabling them on resolved auto-categorization options actions #61804
• Make combined violations as full sentences #61809
• Update Workday.md #61810
• Remove "active" member reference for new Collect pricing #61812
• [No QA] Remove unused images related to subscription help docs #61813
• Include hidden participants for expense member list #61818
• removed bottom padding from FixedFooter of FeedbackSurvey #61828
• [No QA] Fixed generic error page when user is not authenticated #61831
• [CP Staging] [Better Expense Reports]: Fix disabled arrow function #61840
• [NO QA] Remove comment regarding deprecation of User model #61842
• [NO QA] Minor copy improvement #61859
• [CP Staging] Update submodule to 6becb99cfb to unblock deploy #61896
• [CP Staging] Fix action buttons in search row #61903
• fix lhn not show tooltip #61914
• [CP Staging] Add missing React import #61934
• [CP Staging] Enable right component display in search type menu #61952
• Revert "Merge pull request #58608 from nyomanjyotisa/issue-58383" #61955
• Revert "Merge pull request from Krishna2323/krishna2323/issue/60804" - Fix room name mentions #61964
• [CP Staging] Hide empty report view for non-beta users #61967
• [CP Staging] Fix workspace chat showing up #61969
• [CP Staging] Fix amount navigation #61971
• [CP Staging] Use correct reportID when opening a transaction report in RHP #61975
• Revert Pull request #60959 "Improve bottom tab switching by hiding PopoverMenu" #61984
• Revert #60505 "Update onboarding page with new integration choices" #61989
• [CP Staging] Put Add expense button behind the tableReportView beta #62004
• [CP Staging] fix: the attachment picker not show on android #62019
• [CP Staging] fix: unable to delete approval workflow #62023
• [CP Staging] Revert "Stop creating the transaction thread reports optimistically for RequestMoney" #62024
• Render outstanding tooltip only on expense & expense reports page. #61727
• Fix spanish typo #61722
• [Better Expense Report View] Add Transaction Preview RBR based on Report Action Errors + #61580 follow-up #61680
• Fix left group is still shown on the search list #61676
• On leaving room thread, member section should be hidden #61663
• Cycling through reports disappears on hold #61661
• App Crashes When Using Debug Mode to Inspect reportAction  #61658
• fix: an empty report state shows briefly when opening transaction thread in Reports #61657
• Prohibited Expense Change Logs #61627
• [No QA] Commit diff in Podfile.lock #61623
• Fix - Expense - Incorrect payment amount in LHN and report when report has track & submitted expense #61621
• [No QA] Remove unused deps #61620
• Remove a call to getReportNameValuePairs in the debug utilities flow #61617
• Change order of worskpace more features #61601
• Improve type handling / remove casts #61597
• fix : combine intro lines into one line #61592
• Fix after invite user, going back arrived at the invite page again #61585
• [Better Expense Report View] Show Review Required on held expense with violations #61580
• Error messages not displayed consistently for invalid receipt #61467
• Fix open report is called twice when open a chat from start chat page #61447
• Remove old headers implementation #61378
• Add context menu support for long press on demo booking link in EmptySearchView #61357
• fix: Address Confirmation Page UI #61339
• Fix duplicate street name #61319
• fix: your space picture and text are flickering #61312
• fix: duplicate history in mobile chrome #61297
• Fix: Export to accounting software button shows a broken icon #61237
• Fix inconsistencies in selection mode on new report view #61162
• fix: inconsistent bottom bar and search button in not found page #61137
• [Better Expense Reports] Prevent TransactionPreview incomplete viewability #61069
• Room - Archived room still displays the "Join" option when opened #61045
• [UX Reliability] Use new modal for Download PDF on ReportDetailsPage #60956
• Add stricter filtering to task reports #60902
• fix: Global Reimbursements fixes and improvements #60696
• Add unreportedExpense to report page #60352
• [UX Reliability] Use new modal in ConfirmModal #60023
• Empty report chat view #59804
• Fix - Add a setting for creating a different default report title in New Expensify Collect #59568
• Fix - Tax backwards compatibility - After disable Tax in OD display an it's not here page in ND #59565

Internal QA:

• Fix validated code bug on replace card flow #61666 - @mountiny
• [Internal QA] Stage 1: Restyle drop zones #61523 - @blimpich
• [Retract] Add ability to REOPEN report #61370 - @dangrous

Deploy Blockers:

• [Report Creation UI] Total and action columns are not aligned and in the incorrect row #61895
• [Report Creation UI] Workspace chat appears in search results for expense reports. #61915
• Chat - App crashes when right-clicking on message #61921
• mweb - Reports - Bookmark menu is empty after saving search #61924
• [Better Expense Report View] WS Chat - Nothing happens when clicking carousel arrows #61925
• Expense - "Approve" button displays amount on expense preview but not inside report #61926
• Android - Expense - App loads infinitely when trying to add receipt from gallery #61927
• Chat Switching Broken - Always Returns to Same Chat #61928
• [$250] Android-Onboarding - Nothing happens after selecting unsupported integrations and tap Continue #61932
• Web/Desktop - App crashes when selecting status emoji #61938
• [$250] Android - No 3-dot menu on saved search #61939
• Android - Reports - No result page opens and Search field contains long string #61940
• [$125] [Report Creation UI] View button open not here page after submitting a report and viewing it in Reports #61941
• [$125] [Report Creation UI] Not here page opens after clicking Amount in expense thread RHP #61942
• Concierge - Concierge message for category option disappear after selecting a category #61943
• [$250] Chat - Suggestion list reopens and cursor does not move to end after selecting another user #61944
• Search - Unable to open search results #61948
• [$250] WS Setting - Troubleshoot panel appears beneath the Edit Photo RHP #61949
• Expense - Unable to create unreported expense from "Add Expense" button #61950
• [$250] Android - Profile - Gallery only opens after tapping Choose from gallery twice #61951
• [Report Creation UI] App opens expense report after creating unreported expense from main workspace chat #61953
• Onboarding - It redirects to OD by selecting the supported integrations. #61954
• Invoice - Invoice from a deleted workspace can be paid from invoice details #61956
• [$250] Expense- After undo close, Submit, Hold & Delete options are not shown until page is refreshed #61957
• Login - Account closed successfully message is not displayed when close account #61958
• Room - Room is mentioned two times after typing the room name and clicking Enter #61961
• [Better Expense Report Views] Split - Empty report preview appears in group member chat after splitting expense twice #61962
• Expense - In offline, expense details page header & content is inconsistent with online behavior #61963
• [$250] Expense - Expense report does not show transaction details and it only shows the total #61965
• mweb - LHN - Hidden chat displayed on LHN when delete failed scan request #61968
• [$250] Expense - Report is displayed empty when submitting an expense while offline. #61970
• [$250] iOS - LHN - After deleting workspace, report in LHN can only be opened once #61972
• Expense - "Review duplicates" button is unresponsive on expenses report. #61973
• Reports - Selected saved search is not highlighted #61974
• Reports - View button shows a green box when there is one expense in the report #61976
• [Report Creation UI] Expense with violation shows View button on wide screen, Review button on small screen #61977
• Expense - Amount disappears from "Pay" button on report when employee holds an expense. #61978
• [$250] android-workflow-Unable to delete approval workflow #61986
• [Report Creation UI] Expense - Skeleton loader displayed when adding expense to report via "Add Expense" button. #61987
• [Report Creation UI] Expense - Unable to add unreported distance expense to workspace report #61997
• [Report Creation UI] Expense - After adding track expense to workspace report, actionable whisper is still present #61998
• [Report Creation UI] Expense - Track expense created in offline mode is not shown in the list of unreported expense #61999
• [Report Creation UI] Expense - After adding track expense to report offline, expense is not shown in expense report #62001
• [Report Creation UI] Expense - Unreported expense created from OD is not shown in unreported expense list #62006
• Expense - Not here page opens after clicking Edit expense from the expense preview #62012
• Reports - Individual expense row opens expense report instead of transaction thread #62014
• Expense - Navigation arrows are missing on report header RHP when expense is created via FAB #62020
• Per diem - Attendees field does not show "x per person" in per diem transaction thread #62021
• Split - Attendee field is empty when the expense is created from split expense #62031
• [Report Creation UI] Select option is shown by long pressing on empty report, but it cannot be selected #62033
• Reports - Held expense only shows up as a separate report after a browser refresh #62042
• No spacing after punctuation & Learn more link in Upgrade RHP #62066
• "Prevent members from changing custom report name" not toggled off after downgrade WS #62065

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics for this release version and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked Firebase Crashlytics for the previous release version and verified that the release did not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[francoisl]

FYI there's an issue with the Testflight again so you won't have any 9.1.45-0 available for iOS yet. We're looking into it, I'll post an update when it's resolved.

[francoisl]

Testflight builds are available again.

---

Checking 61934/61924 - fix tested internally
#61948 dupe - closed
#61928/#61955 - fix tested on web
#61964/#61961 - fix tested
#61958 – demoted as NAB and probably backend
#61914/#61938/#61921 – fix tested on web
#61956 was demoted – happening on production too
#61967/#61915 – fix tested on staging (still repro with beta tableReportView but out of scope)

[rlinoz]

Demoted #61926

[joekaufmanexpensify]

Checking off #61370 as it is behind beta

[blimpich]

Demoted #61965

[blimpich]

QA-ed #61523

[lakchote]

Demoted #61999 for this reason.

[trjExpensify]

Demoted the issues below for this reason.

#61987
#61997
#61998
#62001
#62006

[kavimuru]

Regression is 4% left in the TR

#61691 (comment)
#61665 (comment)
#61661 failing with #62017 repro in PROD checking it off.
#61543 failing with #61940 on android
#60505 Failing with #61954 and #61932
#60192 failing with #61921

[kavimuru]

@francoisl the following PRs are missing in the checklist now. They were in the list yesterday though.
Could you check please?

#60956
#61069
#61339
#61509
#61601
#61617
#61661
#61663
#61680

[joekaufmanexpensify]

Checked off #61666

[arosiclair]

Demoted #62031

[francoisl]

Demoting #62021
#61932/#61989 - A revert was CPed
#62024/#61973/#62012/#62014 - Revert was CPed, fixes multiple blockers
#61940/#61984 - Fixed, revert was CPed
#62019/#61927
#61963 - same behavior happens on production
#61903/#61895/#61977 - fix confirmed on staging
#62023/#61986 - fix tested on staging
#62042 was demoted
#62004 - confirmed on staging
#61971/#61942 - tested on staging
#61975 - confirmed on staging
#61972 - no longer repro
#61970 - no longer repro

[trjExpensify]

Demoting #62033 for this reason.

[francoisl]

Following up on Vit's comment above (I marked it as hidden to avoid confusion because it included a few incorrect PRs), here's a list of PRs that were missing from the checklist :( I added them to the OP, but we'll unfortunately need to run QA on them before we can close the checklist

#61727
#61722
#61680
#61676
#61663
#61661
#61658
#61657
#61627
#61623
#61621
#61620
#61617
#61601
#61597
#61592
#61585
#61580
#61467
#61447
#61378
#61357
#61339
#61319
#61312
#61297
#61237
#61162
#61137
#61069
#61045
#60956
#60902
#60696
#60352
#60023
#59804
#59568
#59565

[kavimuru]

Regression is just 1 step left.

Unchecked PRs:
#60023 iOS validation is pending
#60192 failing with #61921
#60292 pending validation on all the platforms
#60505 Failing with #61954 and #61932
#60959 (comment) reverted ok to check it off?#61362 failing with #61944 and #61362 (comment)
#61376 failing with #61968
#61529 pending validation on desktop android iOS and failing on web and mweb with this bug id #55349
#61543 failing with #61940 on android
#61665 (comment)
#61691 (comment)
#61760 failing with #61942 and #61953
#61764 failing with #62036 but repro in production checking it off
#61809 pending verification on all the platforms
#61840 validation pending in all the platforms
#61661 failing with #62017 repro in PROD checking it off
#61657 failing with original bug id #61657 (comment)
#61621 validation pending on Web mweb android and iOS
#61617 pending validation on desktop
#61580 pending validation on desktop and ios
#61467 pending validation on all the platforms
#61339 pending validation on all the platforms but iOS
#61297 Pending validation on desktop and iOS
#61237 Pending validation on desktop and iOS
#61045 Pending validation on desktop and iOS and android
#60902 pending validation on all the platforms
#60696 (comment)
#60352 pending validation on desktop android and iOS
#59804 iOS validation is pending
#59568 Pending validation on desktop and iOS
#59565 Pending validation on desktop and iOS

[francoisl]

#60192 failing with #61921

On what platform are you still experiencing the crash? I'm unable to repro on web and desktop

---

#60505 Failing with #61954 and #61932

the original PR was reverted, checking off

#60959 (comment) reverted ok to check it off?

yes – I'm checking it off

#61376 failing with #61968

Can't repro on mweb, checking off

#61543 failing with #61940 on android

Previously retested myself, and can't repro anymore after new retest, checking off

#61657 failing with original bug id #61657 (comment)

PR was reverted, checking off

--

New blockers:

• No spacing after punctuation & Learn more link in Upgrade RHP #62066: minor copy issue, demoted
• "Prevent members from changing custom report name" not toggled off after downgrade WS #62065: will be taken care of in a follow-up PR, demoted