[$250] Android - Profile - Gallery only opens after tapping Choose from gallery twice

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.45-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Samsung Galaxy Z Fold 4 / Android 14
App Component: Other

Action Performed:

1. Launch Expensify app.
2. Go to Account.
3. Tap Profile.
4. Tap on the avatar.
5. Tap Choose from gallery.
6. Tap on the avatar.
7. Tap Choose from gallery.

Expected Result:

In Step 5, device gallery will open.

Actual Result:

In Step 5, device gallery does not open.
In Step 7, after repeating the steps, device gallery opens.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6830132_1747165301795.Screen_Recording_20250514_034017_Photos___videos.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021922536195053093945
• Upwork Job ID: 1922536195053093945
• Last Price Increase: 2025-05-14
• Automatic offers:
• linhvovan29546 | Contributor | 107302757

Issue Owner

Current Issue Owner: @allroundexperts

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @robertjchen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[linhvovan29546]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Android - Profile - Gallery only opens after tapping Choose from gallery twice

What is the root cause of that problem?

Regression from #61165 where we migrated to using a new modal for the Popover. In the AttachmentPicker, we have logic that opens the picker/attachment after the modal is hidden. However, the function is not being called as expected when the modal hides (first time).

App/src/components/AttachmentPicker/index.native.tsx

Line 401 in d814c8f

onModalHide.current = () => {

Why is that?

We passed the ref function directly like this:

App/src/components/AttachmentPicker/index.native.tsx

Line 460 in d814c8f

onModalHide={onModalHide.current}

Since onModalHide.current is a reference to a function, it undefined during the first execution.

In BottomDockedModal, we invoke onModalHide inside onCloseCallback(on Android), which is called using runOnJS. During the first modal close, onModalHide is called with an undefined value due to the way refs work and how runOnJS executes. As a result, the gallery does not show the first time. On the second attempt, the modal re-renders and the ref is defined, so it works.

App/src/components/Modal/BottomDockedModal/index.tsx

Lines 153 to 155 in d814c8f

	if (getPlatform() !== CONST.PLATFORM.IOS) {
	onModalHide();
	}

App/src/components/Modal/BottomDockedModal/Container/index.tsx

Line 41 in d814c8f

runOnJS(onCloseCallBack)();

What changes do you think we should make in order to solve the problem?

To ensure a stable function reference that always reflects the current value, we should wrap the call like this:

                onModalHide={()=> onModalHide.current?.()}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[linhvovan29546]

@robertjchen Happy to raise a PR if this is urgent and my solution works

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021922536195053093945

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[jmusial]

Hey, I'm the author of #61165. @linhvovan29546 s solution LGTM.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[trjExpensify]

@robertjchen did you remove this as a deploy blocker on purpose? It's still unchecked on the deploy checklist.

@linhvovan29546 does your proposal fix this issue and this one: #61927?

[linhvovan29546]

@trjExpensify Yes, I've tested and resolved that as well

[melvin-bot]

📣 @linhvovan29546 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[mountiny]

@linhvovan29546 can you please raise the pr

[linhvovan29546]

Sure!

[linhvovan29546]

the PR is ready ^

[robertjchen]

@trjExpensify Apologies for the confusion there- will make sure to check that moving forward 👀