Skip to content

[UX Reliability] Add new modal for components using Popover #61165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 9, 2025
Merged

[UX Reliability] Add new modal for components using Popover #61165

merged 4 commits into from
May 9, 2025

Conversation

jmusial
Copy link
Contributor

@jmusial jmusial commented Apr 30, 2025 •
edited
Loading

Explanation of Change

We've decided to refactor the react-native-bottom-modal code so that it utilizes react-native-reanimated, our goal was to improve FPS, remove the outdated library and gradually switch to the new solution. This PR enables the new solution in components using Popover, PopoverMenu and PopoverWithMeasuredContent.

Fixed Issues

$ #49354

PROPOSAL:
N/A

Tests

1. Attachment picker

Only on native platforms

  1. Log in to the app
  2. Open a chat
  3. Click "+" next to composer
  4. Modal appears
  5. Click "Add attachment"
  6. Modal appears
2. Button with dropdown menu

For web, only on narrow view

  1. Log in to the app
  2. Go to Reports
  3. Click on a report list item
  4. Click "More" on the top right
  5. Modal appears
3. Three dots menu

For web, only on narrow view

  1. Log in to the app
  2. Go to Account -> Workspaces
  3. Have at least 1 workspace created
  4. Click "three dots" next to workspace name
  5. Modal appears
4. Avatar with image picker

For web, only on narrow view

  1. Log in to the app
  2. Go to Account -> Profile
  3. Click on avatar
  4. Modal appears
5. Security settings page

For web, only on narrow view

  1. Log in to the app
  2. Go to Account -> Security
  3. Add a copilot account
  4. On the list of copilots press "three dots"
  5. Modal appears
6. Account switcher

For web, only on narrow view

  1. Log in to the app
  2. Go to Account -> Security
  3. Add a copilot account
  4. Log in into the copilot account
  5. Go to Account
  6. Press the account switcher (Your name) on top
  7. Modal appears
7. Search type menu

For web, only on narrow view

  1. Log in to the app
  2. Go to Reports
  3. Press the button next to search input
  4. Modal appears
8. Video popover menu

For web, only on narrow view

  1. Log in to the app
  2. Go to a chat
  3. Add a video attachment
  4. Go into video preview
  5. Click "three dots"
  6. Modal appears
  7. Click "Playback speed"
  8. Modal appears
9. FAB Menu

For web, only on narrow view

  1. Log in to the app
  2. Click green "+" at thr right bottom
  3. Modal menu appears
9. Connect to NetSuite

For web, only on narrow view

  1. Log in to the app
  2. Go into Account -> Workspaces
  3. Select and existing one or create a new workspace
  4. Enable accounting in "More features"
  5. Go into Accounting
  6. Click connect next to "NetSuite"
  7. Go through the flow
  8. Once connected press "three dots"
  9. Modal appears
10. Connect to Sage Intacct

For web, only on narrow view

  1. Log in to the app
  2. Go into Account -> Workspaces
  3. Select and existing one or create a new workspace
  4. Enable accounting in "More features"
  5. Go into Accounting
  6. Click connect next to "Sage Intacct"
  7. Go through the flow
  8. Once connected press "three dots"
  9. Modal appears
11. Wallet page

For web, only on narrow view
** Precondition: bank account added in wallet **

  1. Log in to the app
  2. Go into Account -> Wallet
  3. . Press "three dots"
  4. Modal appears

Offline tests

Same as tests

QA Steps

Same as tests

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android_Native.mov
Android: mWeb Chrome
Android_Web.mov
iOS: Native
IOS_Native.mov
iOS: mWeb Safari
IOS_Web.mov
MacOS: Chrome / Safari
Web.mov
MacOS: Desktop

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Apr 30, 2025

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

@jmusial jmusial marked this pull request as ready for review May 5, 2025 09:33
@jmusial jmusial requested a review from a team as a code owner May 5, 2025 09:33
@melvin-bot melvin-bot bot requested review from shawnborton and ZhenjaHorbach and removed request for a team May 5, 2025 09:33
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented May 5, 2025

@shawnborton @ZhenjaHorbach One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@jmusial jmusial mentioned this pull request May 5, 2025
Open
@shawnborton
Copy link
Contributor

Video looks good to me 👍

@ZhenjaHorbach
Copy link
Contributor

ZhenjaHorbach commented May 6, 2025 •
edited
Loading

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
android.mov
Android: mWeb Chrome
android-web.mov
iOS: HybridApp
ios.mov
iOS: mWeb Safari
ios-web.mov
MacOS: Chrome / Safari
web.mov
MacOS: Desktop
web.mov

@blazejkustra
Copy link
Contributor

@ZhenjaHorbach, do you have an estimated time for the review?

@ZhenjaHorbach
Copy link
Contributor

@ZhenjaHorbach, do you have an estimated time for the review?

I will complete a review today or tomorrow !

@ZhenjaHorbach
Copy link
Contributor

@jmusial
Could you please update branch to the latest version of main ?

@melvin-bot melvin-bot bot requested a review from mountiny May 9, 2025 12:08
@ZhenjaHorbach
Copy link
Contributor

LGTM !

mountiny
mountiny previously approved these changes May 9, 2025
View reviewed changes
Copy link
Contributor

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@mountiny mountiny merged commit 2e6eece into Expensify:main May 9, 2025
17 checks passed
@OSBotify
Copy link
Contributor

OSBotify commented May 9, 2025

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions github-actions bot mentioned this pull request May 13, 2025
Closed
@github-actions GitHub Actions
Copy link
Contributor

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.45-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

@github-actions GitHub Actions
Copy link
Contributor

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.45-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@linhvovan29546 linhvovan29546 mentioned this pull request May 14, 2025
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mountiny mountiny mountiny approved these changes

@blazejkustra blazejkustra blazejkustra approved these changes

@ZhenjaHorbach ZhenjaHorbach ZhenjaHorbach approved these changes

@shawnborton shawnborton Awaiting requested review from shawnborton

Assignees

@jmusial jmusial

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jmusial @shawnborton @ZhenjaHorbach @blazejkustra @OSBotify @mountiny