Skip to content

Room - Room is mentioned two times after typing the room name and clicking Enter #61961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 16 tasks
lanitochka17 opened this issue May 13, 2025 · 5 comments
Closed
1 of 16 tasks
Assignees
Labels
Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented May 13, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.45-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/6095266
Issue reported by: Applause - Internal Team

Action Performed:

  1. Navigate to staging.new.expensify.com and sign in with gmail account
  2. Create a workspace and add 2 members to create the announce room
  3. Navigate to any workspace room and start a room mention by typing # in the composer
  4. Select the room suggestion (extra # is added after to room mentioning)
  5. in the composer type # and then type fully the room name from the suggestions, click Enter (the same room mentioning is displayed two times)

Expected Result:

No extra symbols added after selecting the room name from the suggestions list when mentioning a room. The room mentioning is added once to the composer when entering the room name manually and pressing Enter

Actual Result:

Room is mentioned two times after typing the room name and clicking Enter (Web Chrome and Desktop). Extra # is added after selecting a room from the room suggestions list (Web, Desktop and mWeb Safari)

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop
Platforms Tested: On which of our officially supported platforms was this issue tested:
  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6830211_1747170011049.room_mention.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label May 13, 2025
Copy link

melvin-bot bot commented May 13, 2025

Triggered auto assignment to @francoisl (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented May 13, 2025

💬 A slack conversation has been started in #expensify-open-source

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@francoisl
Copy link
Contributor

Found #61362 as the issue, will submit revert shortly.

@francoisl
Copy link
Contributor

Fixed on staging now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

2 participants