fix: ComposeBox - When you click on the mention again, extra characters appear. #61362

Krishna2323 · 2025-05-03T20:03:44Z

Explanation of Change

Fixed Issues

$ #60804
PROPOSAL: #60804 (comment)

Tests

Go to any conversation or create a new one.
In the compose box, type “@”.
Select any user from the list or manually enter a username.
Click in the middle of the username within the mention.
In the window that appears, click on the same user again.
Verify that when you click on the mention again, the cursor is placed after the mention and no extra characters are added.

Verify that no errors appear in the JS console

Offline tests

Go to any conversation or create a new one.
In the compose box, type “@”.
Select any user from the list or manually enter a username.
Click in the middle of the username within the mention.
In the window that appears, click on the same user again.
Verify that when you click on the mention again, the cursor is placed after the mention and no extra characters are added.

QA Steps

Go to any conversation or create a new one.
In the compose box, type “@”.
Select any user from the list or manually enter a username.
Click in the middle of the username within the mention.
In the window that appears, click on the same user again.
Verify that when you click on the mention again, the cursor is placed after the mention and no extra characters are added.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android_native.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: Native

ios_native.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

web_chrome.mp4

MacOS: Desktop

desktop_app.mp4

…rs appear. Signed-off-by: krishna2323 <[email protected]>

Signed-off-by: krishna2323 <[email protected]>

melvin-bot · 2025-05-05T04:18:17Z

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hoangzinh · 2025-05-05T23:08:51Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-05-12.at.20.15.57.android.mov

Android: mWeb Chrome

Screen.Recording.2025-05-12.at.17.27.39.android.chrome.mov

iOS: HybridApp

Screen.Recording.2025-05-12.at.20.27.08.mov

iOS: mWeb Safari

Screen.Recording.2025-05-12.at.20.06.13.ios.safari.mov

MacOS: Chrome / Safari

Screen.Recording.2025-05-12.at.17.18.51.web.mov

MacOS: Desktop

Screen.Recording.2025-05-12.at.17.23.28.desktop.mov

hoangzinh · 2025-05-06T21:54:07Z

src/pages/home/report/ReportActionCompose/SuggestionMention.tsx

@@ -190,6 +190,12 @@ function SuggestionMention(
        [formatLoginPrivateDomain],
    );

+    function getOriginalMentionText(inputValue: string, atSignIndex: number) {
+        const rest = inputValue.slice(atSignIndex);
+        const mentionMatch = rest.match(/^[@\w.\-+]+/); // capture till space or special characters not in emails


@Krishna2323 won't we use MENTION_BREAKER as you mentioned in your proposal? If not can you put this new regrex into a const?

Sorry, my mistake — I've updated it to use MENTION_BREAKER.

Thanks @Krishna2323. Can you elaborate on why we need to use both .search and .match for MENTION_BREAKER? It look like MENTION_BREAKER is not used anywhere

@hoangzinh, I got this solution from AI, and after prompting again, I received the following clarification and updated the code accordingly. I’ve tested the solution as well:

You don’t need both — .search() is sufficient to locate the first breaking character (space, emoji, etc.).
If .match() is also used, it's likely unnecessary unless you want to inspect the actual matched breakers.
In clean implementation, use only .search() with MENTION_BREAKER.

Signed-off-by: krishna2323 <[email protected]>

hoangzinh · 2025-05-08T10:40:24Z

@Krishna2323, can you help to merge the latest main to this PR?

Signed-off-by: krishna2323 <[email protected]>

hoangzinh · 2025-05-09T15:21:54Z

src/pages/home/report/ReportActionCompose/SuggestionMention.tsx

-            updateComment,
-            setSelection,
-        ],
+        [value, suggestionValues.atSignIndex, suggestionValues.suggestedMentions, suggestionValues.prefixType, getMentionCode, updateComment, setSelection],


Does it have a lint issue if we use previous style? I prefer spread in multiple line as previously, it makes code cleaner

I think so, because printWidth is set to 190 and this line only includes 157 characters.

App/.prettierrc.js

Line 7 in 81b1b49

printWidth: 190,

OSBotify · 2025-05-12T20:36:23Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-05-13T18:22:23Z

🚀 Deployed to staging by https://github.com/dangrous in version: 9.1.45-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

github-actions · 2025-05-13T19:32:48Z

🚀 Deployed to staging by https://github.com/dangrous in version: 9.1.45-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

…60804" This reverts commit 228f6b7, reversing changes made to e2d6f3b.

kavimuru · 2025-05-14T22:56:18Z

Failing on iOS with original bug #60804

https://platform.applause.com/services/links/v1/external/6bcb0900040052d25b4fb4987ef00a44e3fecb9a6f790c14303f192c9b433412

mountiny · 2025-05-15T16:40:52Z

@Krishna2323 @hoangzinh can you follow up on that?

github-actions · 2025-05-15T19:01:01Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.1.45-21 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

hoangzinh · 2025-05-15T21:57:15Z

PR was reverted, thus we need to create another one to fix original issue (and DB)

Krishna2323 · 2025-05-16T09:31:55Z

I'll raise the new PR soon.

Krishna2323 added 2 commits May 4, 2025 01:30

fix: ComposeBox - When you click on the mention again, extra characte…

40d3c4b

…rs appear. Signed-off-by: krishna2323 <[email protected]>

fix ESLint.

4f63be9

Signed-off-by: krishna2323 <[email protected]>

Krishna2323 marked this pull request as ready for review May 5, 2025 04:18

Krishna2323 requested a review from a team as a code owner May 5, 2025 04:18

melvin-bot bot requested review from hoangzinh and removed request for a team May 5, 2025 04:18

hoangzinh reviewed May 6, 2025

View reviewed changes

use CONST.REGEX.MENTION_BREAKER.

2f8b903

Signed-off-by: krishna2323 <[email protected]>

Krishna2323 added 2 commits May 9, 2025 14:24

Merge branch 'Expensify:main' into krishna2323/issue/60804

0e6be1c

update getOriginalMentionText to only use search for regex match.

ef5c749

Signed-off-by: krishna2323 <[email protected]>

hoangzinh reviewed May 9, 2025

View reviewed changes

hoangzinh approved these changes May 12, 2025

View reviewed changes

melvin-bot bot requested a review from dangrous May 12, 2025 13:28

dangrous approved these changes May 12, 2025

View reviewed changes

dangrous merged commit 228f6b7 into Expensify:main May 12, 2025
17 of 20 checks passed

github-actions bot mentioned this pull request May 13, 2025

Deploy Checklist: New Expensify 2025-05-13 #61917

Closed

mitarachim mentioned this pull request May 13, 2025

[$250] Chat - Suggestion list reopens and cursor does not move to end after selecting another user #61944

Open

8 tasks

francoisl added a commit that referenced this pull request May 13, 2025

Revert "Merge pull request #61362 from Krishna2323/krishna2323/issue/…

fe5b3e7

…60804" This reverts commit 228f6b7, reversing changes made to e2d6f3b.

This was referenced May 13, 2025

Room - Room is mentioned two times after typing the room name and clicking Enter #61961

Closed

Revert "Merge pull request from Krishna2323/krishna2323/issue/60804" - Fix room name mentions #61964

Merged

github-actions bot mentioned this pull request May 16, 2025

Deploy Checklist: New Expensify 2025-05-15 #62161

Open

79 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: ComposeBox - When you click on the mention again, extra characters appear. #61362

fix: ComposeBox - When you click on the mention again, extra characters appear. #61362

Krishna2323 commented May 3, 2025 •

edited

Loading

melvin-bot bot commented May 5, 2025

hoangzinh commented May 5, 2025 •

edited

Loading

hoangzinh May 6, 2025

Krishna2323 May 8, 2025

hoangzinh May 8, 2025

Krishna2323 May 9, 2025

hoangzinh commented May 8, 2025

hoangzinh May 9, 2025

Krishna2323 May 11, 2025

OSBotify commented May 12, 2025

github-actions bot commented May 13, 2025

github-actions bot commented May 13, 2025

kavimuru commented May 14, 2025

mountiny commented May 15, 2025

github-actions bot commented May 15, 2025

hoangzinh commented May 15, 2025

Krishna2323 commented May 16, 2025

fix: ComposeBox - When you click on the mention again, extra characters appear. #61362

fix: ComposeBox - When you click on the mention again, extra characters appear. #61362

Conversation

Krishna2323 commented May 3, 2025 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented May 5, 2025

hoangzinh commented May 5, 2025 • edited Loading

Reviewer Checklist

Screenshots/Videos

hoangzinh May 6, 2025

Choose a reason for hiding this comment

Krishna2323 May 8, 2025

Choose a reason for hiding this comment

hoangzinh May 8, 2025

Choose a reason for hiding this comment

Krishna2323 May 9, 2025

Choose a reason for hiding this comment

hoangzinh commented May 8, 2025

hoangzinh May 9, 2025

Choose a reason for hiding this comment

Krishna2323 May 11, 2025

Choose a reason for hiding this comment

OSBotify commented May 12, 2025

github-actions bot commented May 13, 2025

github-actions bot commented May 13, 2025

kavimuru commented May 14, 2025

mountiny commented May 15, 2025

github-actions bot commented May 15, 2025

hoangzinh commented May 15, 2025

Krishna2323 commented May 16, 2025

Krishna2323 commented May 3, 2025 •

edited

Loading

hoangzinh commented May 5, 2025 •

edited

Loading