Fix - Add Custom field 1 and Custom field 2 in the workspace member profile. #60277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dannymcclain Mind u give a quick 👀 as it is a new feature Thx |
|
Videos are looking good to me! Do these fields only show up on the Members detail page? Or do they also show up as read-only on the user's profile? |
|
@dannymcclain They are currently displayed only on the member detail page and not on the user's profile. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2025-05-09.at.3.23.38.PM.movAndroid: mWeb ChromeScreen.Recording.2025-05-09.at.11.04.55.AM.moviOS: HybridAppSimulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-05-09.at.11.06.42.mp4iOS: mWeb SafariSimulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-05-09.at.11.03.26.mp4MacOS: Chrome / Safariweb.movMacOS: Desktopdesktop.mov |
|
@rayane-d how are you getting on with the review here? CC: @zsgreenwald to follow along as you have a lead asking for this. |
rayane-d
suggested changes
Apr 28, 2025
There was a problem hiding this comment.
@FitseTLT Let's add logic to properly handle the POLICYCHANGELOG_UPDATE_EMPLOYEE report action in the #admin room; it currently displays the message for member role updates instead of custom field updates.
The message should be added an <employeeUserID / employeePayrollID> of "<Value>" to <User> or updated the <employeeUserID / employeePayrollID> of <User> to "<Value>" (previously "<Value>")
We also need to include translations for these messages.
Here is the JSON data of a sample action:
JSON Data
{
"actionName": "POLICYCHANGELOG_UPDATE_EMPLOYEE",
"actorAccountID": 19723429,
"avatar": "https://d2k5nsl2zxldvw.cloudfront.net/images/avatars/default-avatar_14.png",
"created": "2025-04-28 18:47:56.435",
"lastModified": "2025-04-28 18:47:56.435",
"message": [
{
"type": "COMMENT",
"html": "added a employeePayrollID of \"Test adm 2\" to [email protected]",
"text": "added a employeePayrollID of \"Test adm 2\" to [email protected]",
"isEdited": false,
"whisperedTo": [],
"isDeletedParentAction": false,
"deleted": "",
"reactions": []
}
],
"originalMessage": {
"accountID": 19723429,
"email": "[email protected]",
"field": "employeePayrollID",
"isNewDot": true,
"lastModified": "2025-04-28 18:47:56.435",
"newValue": "Test adm 2",
"oldValue": ""
},
"person": [
{
"type": "TEXT",
"style": "strong",
"text": "Admin"
}
],
"reportActionID": "431092518121503504",
"shouldShow": true,
"timestamp": 1745866076,
"reportActionTimestamp": 1745866076435,
"automatic": false,
"whisperedToAccountIDs": []
}
|
BUG: The custom field page opens without a sliding animation. Screen.Recording.2025-04-28.at.8.08.09.PM.mov |
rayane-d
suggested changes
Apr 28, 2025
rayane-d
suggested changes
Apr 28, 2025
src/pages/workspace/members/WorkspaceMembersCustomFieldsPage.tsx
Outdated
Show resolved
Hide resolved
rayane-d
suggested changes
May 1, 2025
|
@FitseTLT Any update? |
Yep, they do. No conditional logic. They live here on every member in the people table on OldDot: 
Companies use these fields to store additional info about employees, to mainly then include in manual CSV exports. E.g employeeID, cost centre etc. |
|
Right on, thanks for confirming! |
|
cc @Expensify/design for viz, this is a "new" thing for NewDot to keep in mind. |
|
Cool, so we're only short one review from @francoisl and then we can get this merged, right? |
francoisl
approved these changes
May 12, 2025
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
github-actions
bot
added
the
DeployBlockerCash
Performance Comparison Report 📊 (1/11)Significant Changes To Duration
Show details
|
Performance Comparison Report 📊 (10/11)Meaningless Changes To Duration (9/10)Show entries
Show details
|
Performance Comparison Report 📊 (11/11)Meaningless Changes To Duration (10/10)Show entries
Show details
|
Performance Comparison Report 📊 (2/11)Meaningless Changes To Duration (1/10)Show entries
Show details
|
Performance Comparison Report 📊 (3/11)Meaningless Changes To Duration (2/10)Show entries
Show details
|
Performance Comparison Report 📊 (4/11)Meaningless Changes To Duration (3/10)Show entries
Show details
|
Performance Comparison Report 📊 (5/11)Meaningless Changes To Duration (4/10)Show entries
Show details
|
Performance Comparison Report 📊 (6/11)Meaningless Changes To Duration (5/10)Show entries
Show details
|
Performance Comparison Report 📊 (7/11)Meaningless Changes To Duration (6/10)Show entries
Show details
|
Performance Comparison Report 📊 (8/11)Meaningless Changes To Duration (7/10)Show entries
Show details
|
Performance Comparison Report 📊 (9/11)Meaningless Changes To Duration (8/10)Show entries
Show details
|
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
51 tasks
|
Sounds like a false positive, I reran the E2E tests in a revert PR and it gave higher results for the https://github.com/Expensify/App/actions/runs/14981705901/job/42088935414#step:19:61
|
francoisl
removed
the
DeployBlockerCash
|
🚀 Deployed to staging by https://github.com/francoisl in version: 9.1.45-0 🚀
|
|
🚀 Deployed to staging by https://github.com/francoisl in version: 9.1.45-0 🚀
|
|
🚀 Deployed to production by https://github.com/francoisl in version: 9.1.45-21 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fixed Issues
$ #59243
PROPOSAL: #59243 (comment)
Tests
Offline tests
Same as above
QA Steps
Same as above
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel so the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
2025-04-25.00-13-26.mp4
Android: mWeb Chrome
2025-04-25.00-15-37.mp4
iOS: Native
2025-04-24.23-09-40.mp4
iOS: mWeb Safari
2025-04-24.23-10-33.mp4
MacOS: Chrome / Safari
2025-04-24.23-08-28.mp4
MacOS: Desktop
2025-04-24.23-09-06.mp4