[$250] Android - No 3-dot menu on saved search

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.45-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Samsung Galaxy Z Fold 4 / Android 14
App Component: Search

Action Performed:

1. Launch Expensify app.
2. Go to Reports.
3. Tap Filters.
4. Tap Expense type.
5. Select any type and tap Save.
6. Tap Save search.
7. Tap bookmark icon.

Expected Result:

Saved search will have 3-dot menu for rename and delete options.

Actual Result:

No 3-dot menu on saved search

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6830107_1747164105195.Screen_Recording_20250514_030126_Expensify.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021922380433473807750
• Upwork Job ID: 1922380433473807750
• Last Price Increase: 2025-05-13
• Automatic offers:
• gijoe0295 | Contributor | 107293784

Issue Owner

Current Issue Owner: @alitoshmatov

[melvin-bot]

Triggered auto assignment to @marcochavezf (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[marcochavezf]

This is also happening on web

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021922380433473807750

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

[gijoe0295]

🚨 Edited by proposal-police: This proposal was edited at 2025-05-13 20:10:18 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

No 3-dot menu on saved search

What is the root cause of that problem?

Offending PR: #60959

cc @aldo-expensify because you are working on the revert.

shouldShowRightComponent is false by default in MenuItem

App/src/components/MenuItem.tsx

Line 443 in 7012435

shouldShowRightComponent = false,

When building the menu items, we do not enable it here:

App/src/hooks/useSearchTypeMenu.tsx

Lines 149 to 174 in 748a88b

	return {
	text: savedSearchTitle,
	onSelected: () => {
	clearAllFilters();
	Navigation.navigate(ROUTES.SEARCH_ROOT.getRoute({query: item?.query ?? '', name: item?.name}));
	},
	rightComponent: (
	<ThreeDotsMenu
	menuItems={getOverflowMenu(baseMenuItem.title ?? '', Number(baseMenuItem.hash ?? ''), item.query ?? '')}
	anchorPosition={{horizontal: 0, vertical: 380}}
	anchorAlignment={{
	horizontal: CONST.MODAL.ANCHOR_ORIGIN_HORIZONTAL.RIGHT,
	vertical: CONST.MODAL.ANCHOR_ORIGIN_VERTICAL.TOP,
	}}
	disabled={item.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE}
	/>
	),
	style: [styles.textSupporting],
	isSelected: false,
	shouldCallAfterModalHide: true,
	icon: Expensicons.Bookmark,
	iconWidth: variables.iconSizeNormal,
	iconHeight: variables.iconSizeNormal,
	shouldIconUseAutoWidthStyle: false,
	hash: key,
	};

This only happens on small screens because we use SearchTypeMenuPopover on small screens and SearchTypeMenu on large ones. In SearchTypeMenu, we already enabled shouldShowRightComponent:

App/src/pages/Search/SearchTypeMenu.tsx

Line 87 in b033a64

const baseMenuItem: SavedSearchMenuItem = createBaseSavedSearchMenuItem(item, key, index, title, isItemFocused);

App/src/libs/SearchUIUtils.ts

Line 931 in a4b561c

shouldShowRightComponent: true,

What changes do you think we should make in order to solve the problem?

Add shouldShowRightComponent: true, to the saved search menu item in SearchTypeMenuPopover.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

None

[marcochavezf]

Thanks @gijoe0295, I tested the solution locally and it's working. I created a PR for this. I will assign you for the payment

[melvin-bot]

📣 @gijoe0295 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[marcochavezf]

CP requested https://expensify.slack.com/archives/C07J32337/p1747168532254549

[LorenzoBloedow]

@marcochavezf Sorry for the ping, but I tried to reproduce the solution and couldn't make it work.

Are we supposed to test our changes in staging or main? I've been testing on main since all the latest changes seem to get merged there. But also tried staging and in both shouldShowRightComponent is already true.

I feel like I'm missing something very obvious here, so I apologize in advance.

[marcochavezf]

Hi @LorenzoBloedow!

Are we supposed to test our changes in staging or main? I've been testing on main since all the latest changes seem to get merged there. But also tried staging and in both shouldShowRightComponent is already true.

Yup, you're right, it should be in main. I think you're seeing the shouldShowRightComponent because the fix was already merged here and cherry-picked to staging

Ah also, this is happening on small screens, if you are running the app on a big screen the bookmark icon won't be shown there

[marcochavezf]

Tested on staging and the 3-dot menu is there

Removing the deploy blocker label