Skip to content

"Prevent members from changing custom report name" not toggled off after downgrade WS #62065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
4 of 8 tasks
mitarachim opened this issue May 15, 2025 · 13 comments
Open
4 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Reviewing Has a PR in review

Comments

@mitarachim
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v9.1.45-18
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: Exploratory around #59568
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Windows 11/Chrome, iPhone 16/iOS 18.3.1
App Component: Workspace Settings

Action Performed:

  1. Navigate to staging.new.expensify.com
  2. Create new account
  3. Go to Accounts >> Workspaces >> Create new workspace
  4. Go to workspace settings >> Reports option
  5. Toggle on "Prevent members from changing custom report name"
  6. Click Upgrade
  7. Click "View your subscription" link
  8. Select Explore all plans button
  9. Downgrade to Collect WS
  10. Go to Workspaces & select the collect WS
  11. Click Reports option & observe "Prevent members from changing custom report name" toggle is on

Expected Result:

"Prevent members from changing custom report name" should automatically toggle off after downgrading WS to Collect WS

Actual Result:

"Prevent members from changing custom report name" not automatically toggled off after downgrading WS to collect WS.
Issue does not happen for Report fields option. When workspace is downgraded to WS, report field toggle button is OFF as expected

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6831686_1747276595437.Recording__160.mp4

View all open jobs on GitHub

@mitarachim mitarachim added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels May 15, 2025
Copy link

melvin-bot bot commented May 15, 2025

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented May 15, 2025

Triggered auto assignment to @MonilBhavsar (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented May 15, 2025

💬 A slack conversation has been started in #expensify-open-source

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@francoisl
Copy link
Contributor

I don't think this is worth being a deploy blocker, we can fix it in a follow-up PR. Also it might require backend changes to disable that feature when you downgrade a policy.

@MonilBhavsar MonilBhavsar added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 DeployBlocker Indicates it should block deploying the API labels May 15, 2025
@MonilBhavsar
Copy link
Contributor

@suneox
Copy link
Contributor

suneox commented May 15, 2025

It seems to be a backend issue after downgrade to Collect WS does not disable areReportFieldsEnabled

@MonilBhavsar
Copy link
Contributor

Thanks! Discussing in the slack thread about next steps

@FitseTLT
Copy link
Contributor

@MonilBhavsar U can add a note to handle this in #61612 and close this as it should normally handle it.

@melvin-bot melvin-bot bot added the Overdue label May 19, 2025
Copy link

melvin-bot bot commented May 19, 2025

@miljakljajic, @MonilBhavsar Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@miljakljajic
Copy link
Contributor

Being handled in #61612

@carlosmiceli carlosmiceli reopened this May 20, 2025
@carlosmiceli carlosmiceli self-assigned this May 20, 2025
@carlosmiceli
Copy link
Contributor

Reopening because this issue does not follow the same logic as downgrading approval workflow. Will solve in another PR.

@melvin-bot melvin-bot bot added the Overdue label May 23, 2025
@carlosmiceli
Copy link
Contributor

PR is up for review.

@melvin-bot melvin-bot bot removed the Overdue label May 23, 2025
@carlosmiceli carlosmiceli added the Reviewing Has a PR in review label May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

7 participants