Skip to content

Invoice - Invoice from a deleted workspace can be paid from invoice details #61956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
3 of 8 tasks
vincdargento opened this issue May 13, 2025 · 10 comments
Open
3 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@vincdargento
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v9.1.45-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/cases/view/3073290
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: Windows 10 / Chrome, Samsung Galaxy A12 / Android 13
App Component: Money Requests

Action Performed:

Precondition: User A has sent an invoice to user B

  1. Go to staging.new.expensify.com
  2. Access the invoice room as both user
  3. As user A, delete the workspace associated with the invoice
  4. As user B, click on the invoice preview

Expected Result:

Pay button not displayed in preview and details view

Actual Result:

Pay button is displayed in invoice details view

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

@vincdargento vincdargento added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels May 13, 2025
Copy link

melvin-bot bot commented May 13, 2025

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented May 13, 2025

Triggered auto assignment to @aldo-expensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@github-actions github-actions bot added the Hourly KSv2 label May 13, 2025
Copy link

melvin-bot bot commented May 13, 2025

💬 A slack conversation has been started in #expensify-open-source

@vincdargento
Copy link
Author

@maddylewis FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@aldo-expensify
Copy link
Contributor

I'm investigating this, I reproduced in dev but still haven't found the cause

@aldo-expensify
Copy link
Contributor

This also happens in production:

Image Image

No idea if this behaviour changed on purpose.

@aldo-expensify aldo-expensify added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels May 14, 2025
@aldo-expensify
Copy link
Contributor

Asking if this is expected behaviour and we should update the test rail test or if this is wrong: https://expensify.slack.com/archives/C03U7DCU4/p1747183929623809

Doesn't sound wrong to me that the receiver can pay the invoice even after the workspace is deleted. 🤷

@maddylewis
Copy link
Contributor

Doesn't sound wrong to me that the receiver can pay the invoice even after the workspace is deleted. 🤷

agree, that seems like expected behavior IMO.

@aldo-expensify
Copy link
Contributor

Ok, this was discussed here and we will proceed with the expected result of this issue: https://expensify.slack.com/archives/C03U7DCU4/p1747241562756039?thread_ts=1747183929.623809&cid=C03U7DCU4

@aldo-expensify aldo-expensify added the Help Wanted Apply this label when an issue is open to proposals by contributors label May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

3 participants