[Retract] Add ability to REOPEN report #61370

rushatgabhane · 2025-05-04T21:20:37Z

Explanation of Change

Fixed Issues

$ #59561
PROPOSAL:

Tests

Go to a workspace that has reports in closed state.
Click more
Verify that you see "Undo close"
Verify that clicking undo close changes the report's state back to open.
Verify that you see a system message in the chat - 'reopened'

Exported report

Go to a closed report that has been exported to accounting
Click more
Verify you see a modal - This report has already been exported to X.
Verify that clicking reopen report in the model reopens the report. And that it is in open state.
Verify that you see a reopened message.

Verify that no errors appear in the JS console

Offline tests

QA Steps

same as tests

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified there are no new alerts related to the canBeMissing param for useOnyx
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2025-05-12.at.01.01.45.mov

MacOS: Desktop

melvin-bot · 2025-05-04T21:20:43Z

@ahmedGaber93 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

joekaufmanexpensify · 2025-05-05T13:34:27Z

@ahmedGaber93 shared design doc you need to review this

ahmedGaber93 · 2025-05-06T06:21:51Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Failed to build the android app, but testing the other platform should be enough.

Android: mWeb Chrome

aw.mp4

iOS: HybridApp

i.mp4

iOS: mWeb Safari

iw.mp4

MacOS: Chrome / Safari

w.mp4

MacOS: Desktop

d.mp4

ahmedGaber93

Minor notes

src/components/MoneyReportHeader.tsx

src/languages/en.ts

src/languages/es.ts

src/libs/API/parameters/ReopenReportParams.ts

src/libs/actions/IOU.ts

ahmedGaber93 · 2025-05-08T17:05:02Z

@rushatgabhane Thanks for the update!

Could you please fill the Tests and Screenshots/Videos sections, and add confirm the translation on slack? Thanks.

ahmedGaber93 · 2025-05-09T09:08:47Z

Bug: two message "reopened" after undo close
Bug: submit button not appear again after undo close util refreshing the page

Looks like are a backend issues

20250509115841156.mp4

ahmedGaber93 · 2025-05-09T09:53:16Z

Minor bug: missing space after heads up!

rushatgabhane · 2025-05-11T23:08:29Z

@ahmedGaber93 resolved all the issues. Note that you will see the report actions disappear after you reopen the report.
This is a backend bug. Kindly ignore it and test offline. It will be fixed in parallel, and it should not slow the merge because the feature is behind a beta.

Screen.Recording.2025-05-12.at.00.59.36.mov

ahmedGaber93 · 2025-05-12T01:11:30Z

@rushatgabhane FYI the undefined here is not an issue, it because I just force open the modal to review the style but no integration is connected, so let's revert getIntegrationNameFromExportMessage as it looks redundant and may return incorrect value if we have more than one exportIntegrationAction.

ahmedGaber93 · 2025-05-12T01:29:24Z

Also, please note to confirm the translation on slack. Thanks!

ahmedGaber93

It works well, just one comment still need to be addressed #61370 (comment) plus confirm the translation on slack.

CC @dangrous

rushatgabhane · 2025-05-12T02:04:36Z

FYI the undefined here is not an issue, it because I just force open the modal to review the style but no integration is connected, so let's revert getIntegrationNameFromExportMessage as it looks redundant and may return incorrect value if we have

So my reasoning is: when you disconnect an accounting integration, or change accounting integration we will have to handle that case.

The currently connected integration is outdated. We need to get the integration that the report was exported to

ahmedGaber93 · 2025-05-12T02:32:09Z

Ah, good catch!

src/languages/es.ts

src/libs/ReportUtils.ts

shubham1206agra · 2025-05-12T16:21:25Z

@dangrous Can you hold the approval here?

Co-authored-by: Shubham Agrawal <[email protected]>

…/reopen

rushatgabhane · 2025-05-12T17:35:24Z

pushed translations

shubham1206agra · 2025-05-12T18:09:06Z

@ahmedGaber93 Please retest this PR on all platforms. Since significant changes happened here

ahmedGaber93 · 2025-05-12T18:52:08Z

@rushatgabhane why you didn't confirm the translation on slack?

rushatgabhane · 2025-05-12T18:53:48Z

it is from figma

ahmedGaber93 · 2025-05-12T18:57:49Z

Ah, I just wanted to confirm it is approved.

ahmedGaber93 · 2025-05-12T19:57:35Z

@shubham1206agra Thanks for contributing ❤️

dangrous

Looks good! Let's push this out

OSBotify · 2025-05-12T20:58:36Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-05-13T18:22:26Z

🚀 Deployed to staging by https://github.com/dangrous in version: 9.1.45-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

joekaufmanexpensify · 2025-05-13T18:36:53Z

I am testing this here.

github-actions · 2025-05-13T19:32:51Z

🚀 Deployed to staging by https://github.com/dangrous in version: 9.1.45-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

joekaufmanexpensify · 2025-05-15T13:26:19Z

Found some bugs when testing this PR.

github-actions · 2025-05-15T19:01:04Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.1.45-21 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

rushatgabhane added 8 commits May 4, 2025 23:17

add reopen report

20c0661

+ reopen report to const

7e6d35a

add reopen report to header

18fa2cd

add lang

bd294ad

add retract beta

6d9a048

add reopen to more actions btn

978dc62

api types for reopen

3a0c2ee

add reopen api command

03df005

rushatgabhane requested a review from a team as a code owner May 4, 2025 21:20

melvin-bot bot requested a review from ahmedGaber93 May 4, 2025 21:20

melvin-bot bot removed the request for review from a team May 4, 2025 21:20

rushatgabhane mentioned this pull request May 4, 2025

Add ability to reopen report #60138

Closed

50 tasks

add reopen behind beta

e7a4e81

ahmedGaber93 reviewed May 6, 2025

View reviewed changes

rushatgabhane added 2 commits May 8, 2025 11:08

add missing lang

9546b6c

Merge remote-tracking branch 'origin' into feat/reopen

2467964

rushatgabhane requested a review from ahmedGaber93 May 8, 2025 09:21

heads up with bold style

2fba6c5

rushatgabhane added 2 commits May 12, 2025 01:11

clean up reopen state

e09afc2

fix type

54f2e37

ahmedGaber93 approved these changes May 12, 2025

View reviewed changes

melvin-bot bot requested a review from dangrous May 12, 2025 01:34

shubham1206agra reviewed May 12, 2025

View reviewed changes

src/languages/es.ts Outdated Show resolved Hide resolved

shubham1206agra reviewed May 12, 2025

View reviewed changes

src/libs/ReportUtils.ts Outdated Show resolved Hide resolved

rushatgabhane and others added 2 commits May 12, 2025 18:23

Update src/languages/es.ts

19650d1

Co-authored-by: Shubham Agrawal <[email protected]>

add translation for reopened

d24464f

rushatgabhane requested a review from ahmedGaber93 May 12, 2025 17:34

Merge branch 'feat/reopen' of github.com:rushatgabhane/exfy into feat…

b0d0b20

…/reopen

pretty me

76bce30

ahmedGaber93 approved these changes May 12, 2025

View reviewed changes

dangrous approved these changes May 12, 2025

View reviewed changes

dangrous merged commit c7d6a67 into Expensify:main May 12, 2025
17 checks passed

This was referenced May 12, 2025

Investigate workflow job failing on main: e2ePerformanceTests / Run E2E tests in AWS device farm #61881

Closed

Deploy Checklist: New Expensify 2025-05-13 #61917

Closed

joekaufmanexpensify added the InternalQA This pull request required internal QA label May 13, 2025

mitarachim mentioned this pull request May 13, 2025

[$250] Expense- After undo close, Submit, Hold & Delete options are not shown until page is refreshed #61957

Open

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Retract] Add ability to REOPEN report #61370

[Retract] Add ability to REOPEN report #61370

rushatgabhane commented May 4, 2025 •

edited

Loading

melvin-bot bot commented May 4, 2025

joekaufmanexpensify commented May 5, 2025

ahmedGaber93 commented May 6, 2025 •

edited

Loading

ahmedGaber93 left a comment

ahmedGaber93 commented May 8, 2025 •

edited

Loading

ahmedGaber93 commented May 9, 2025

ahmedGaber93 commented May 9, 2025

rushatgabhane commented May 11, 2025 •

edited

Loading

ahmedGaber93 commented May 12, 2025 •

edited

Loading

ahmedGaber93 commented May 12, 2025

ahmedGaber93 left a comment •

edited

Loading

rushatgabhane commented May 12, 2025 •

edited

Loading

ahmedGaber93 commented May 12, 2025

shubham1206agra commented May 12, 2025

rushatgabhane commented May 12, 2025

shubham1206agra commented May 12, 2025

ahmedGaber93 commented May 12, 2025

rushatgabhane commented May 12, 2025

ahmedGaber93 commented May 12, 2025

ahmedGaber93 commented May 12, 2025

dangrous left a comment

OSBotify commented May 12, 2025

github-actions bot commented May 13, 2025

joekaufmanexpensify commented May 13, 2025

github-actions bot commented May 13, 2025

joekaufmanexpensify commented May 15, 2025

github-actions bot commented May 15, 2025

[Retract] Add ability to REOPEN report #61370

[Retract] Add ability to REOPEN report #61370

Conversation

rushatgabhane commented May 4, 2025 • edited Loading

Explanation of Change

Fixed Issues

Tests

Exported report

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented May 4, 2025

joekaufmanexpensify commented May 5, 2025

ahmedGaber93 commented May 6, 2025 • edited Loading

Reviewer Checklist

Screenshots/Videos

ahmedGaber93 left a comment

Choose a reason for hiding this comment

ahmedGaber93 commented May 8, 2025 • edited Loading

ahmedGaber93 commented May 9, 2025

ahmedGaber93 commented May 9, 2025

rushatgabhane commented May 11, 2025 • edited Loading

ahmedGaber93 commented May 12, 2025 • edited Loading

ahmedGaber93 commented May 12, 2025

ahmedGaber93 left a comment • edited Loading

Choose a reason for hiding this comment

rushatgabhane commented May 12, 2025 • edited Loading

ahmedGaber93 commented May 12, 2025

shubham1206agra commented May 12, 2025

rushatgabhane commented May 12, 2025

shubham1206agra commented May 12, 2025

ahmedGaber93 commented May 12, 2025

rushatgabhane commented May 12, 2025

ahmedGaber93 commented May 12, 2025

ahmedGaber93 commented May 12, 2025

dangrous left a comment

Choose a reason for hiding this comment

OSBotify commented May 12, 2025

github-actions bot commented May 13, 2025

joekaufmanexpensify commented May 13, 2025

github-actions bot commented May 13, 2025

joekaufmanexpensify commented May 15, 2025

github-actions bot commented May 15, 2025

rushatgabhane commented May 4, 2025 •

edited

Loading

ahmedGaber93 commented May 6, 2025 •

edited

Loading

ahmedGaber93 commented May 8, 2025 •

edited

Loading

rushatgabhane commented May 11, 2025 •

edited

Loading

ahmedGaber93 commented May 12, 2025 •

edited

Loading

ahmedGaber93 left a comment •

edited

Loading

rushatgabhane commented May 12, 2025 •

edited

Loading