Skip to content

[$250] Expense- After undo close, Submit, Hold & Delete options are not shown until page is refreshed #61957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
6 of 8 tasks
mitarachim opened this issue May 13, 2025 · 16 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff

Comments

@mitarachim
Copy link

mitarachim commented May 13, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.45-1
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught during regression testing, add the test name, ID and link from TestRail: #61370
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Create a workspace and disable Workflows feature in Workspaces > More features page.
  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Submit a manual expense.
  4. Click on the expense preview.
  5. Click More.
  6. Click Undo close.
  7. Click More.
  8. Note that Submit, Hold and Delete option are missing.
  9. Refresh the page.
  10. Click More.
  11. Now Submit, Hold and Delete option are shown.

Expected Result:

After undo close, Submit, Hold and Delete option will be present in More menu without refreshing the page.

Actual Result:

After undo close, Submit, Hold and Delete option are absent in More menu. The options are only shown after refreshing the page.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6830187_1747168580793.20250514_043219.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021922399534196538142
  • Upwork Job ID: 1922399534196538142
  • Last Price Increase: 2025-05-13
Issue OwnerCurrent Issue Owner: @fedirjh
@mitarachim mitarachim added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels May 13, 2025
Copy link

melvin-bot bot commented May 13, 2025

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented May 13, 2025

Triggered auto assignment to @neil-marcellini (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented May 13, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels May 13, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@neil-marcellini
Copy link
Contributor

This was just added which is why it can't be reproduced on prod. However, it was added under a beta and therefore it's not a blocker.

@neil-marcellini neil-marcellini added External Added to denote the issue can be worked on by a contributor Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 DeployBlocker Indicates it should block deploying the API labels May 13, 2025
Copy link

melvin-bot bot commented May 13, 2025

Job added to Upwork: https://www.upwork.com/jobs/~021922399534196538142

@melvin-bot melvin-bot bot changed the title Expense- After undo close, Submit, Hold & Delete options are not shown until page is refreshed [$250] Expense- After undo close, Submit, Hold & Delete options are not shown until page is refreshed May 13, 2025
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label May 13, 2025
Copy link

melvin-bot bot commented May 13, 2025

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

@aadil42
Copy link

aadil42 commented May 13, 2025

Image

@mitarachim, I don't have "Undo close" when clicking on More. Can you help? This was on staging.

@mitarachim
Copy link
Author

@aadil42 we don't have any additional steps . only follow all steps above in staging and issue always reproduce.
also don't forget to run precondition.

@joekaufmanexpensify
Copy link
Contributor

This is behind beta. @rushatgabhane will address as he is working on this project.

@rushatgabhane
Copy link
Member

rushatgabhane commented May 13, 2025

@joekaufmanexpensify this is a backend bug. Probably already being fixed by @dangrous' changes

@rushatgabhane
Copy link
Member

backend because this is not reproducible offline

@aadil42
Copy link

aadil42 commented May 14, 2025

@mitarachim, here are the steps I followed:

Screen.Recording.2025-05-14.at.2.mp4

@rushatgabhane
Copy link
Member

#61957 (comment)

@joekaufmanexpensify
Copy link
Contributor

Sounds like this should be fixed by @dangrous PR here then.

@neil-marcellini neil-marcellini added Internal Requires API changes or must be handled by Expensify staff and removed External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors labels May 14, 2025
@dangrous
Copy link
Contributor

hrm I can look into this on Monday - I'm not sure it will be fixed by the existing PR.

What are the details about the report that the frontend is looking for in order to show those options? It may need a separate Onyx update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Development

No branches or pull requests

8 participants