Fix - Tax backwards compatibility - After disable Tax in OD display an it's not here page in ND #59565

FitseTLT · 2025-04-02T19:04:37Z

Details

Fixed Issues

$ #59076
PROPOSAL: #59076 (comment)

Tests

Login and create a Collect policy (NewDot compatible)
In OldDot - Enable Tax in the workspace
Click on the Tax page in ND
Toggle the Tax feature off from OldDot
Switch to ND
Verify that you are navigated to more features page

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Same as above

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

2025-04-02.22-03-20.mp4

Android: mWeb Chrome

2025-04-02.22-02-11.mp4

iOS: Native

2025-04-02.21-49-34.mp4

iOS: mWeb Safari

2025-04-02.21-46-39.mp4

MacOS: Chrome / Safari

2025-04-02.21-45-01.mp4

MacOS: Desktop

2025-04-02.21-45-53.mp4

…n-OD

melvin-bot · 2025-04-02T19:04:42Z

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/pages/workspace/AccessOrNotFoundWrapper.tsx

…n-OD

src/pages/workspace/AccessOrNotFoundWrapper.tsx

…n-OD

eVoloshchak · 2025-04-15T07:04:09Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-05-08.at.10.54.03.mov

Android: mWeb Chrome

Screen.Recording.2025-05-08.at.10.52.13.mov

iOS: Native

Screen.Recording.2025-05-08.at.10.47.18.mov

iOS: mWeb Safari

Screen.Recording.2025-05-08.at.10.46.46.mov

MacOS: Chrome / Safari

Screen.Recording.2025-05-08.at.10.28.29.mov

MacOS: Desktop

Screen.Recording.2025-05-08.at.10.49.11.mov

eVoloshchak

Verify that you are navigated to more features page

I realized this when testing mWeb, since it's not clear with the wide screen layout, but we're navigating to the wrong page.
The expected result in #59076 states that the user should be navigated to The Workspace settings, not to More Features

Screen.Recording.2025-04-16.at.09.26.32.mov

FitseTLT · 2025-04-16T12:14:51Z

@eVoloshchak I followed @neil-marcellini suggestion here

eVoloshchak

Bug:

Enable a workspace feature (for example, Taxes)
Go to that feature page
Copy the URL
Go back to More Features page, disable the feature
Paste the URL and navigate to it
Notice the page is still displayed even though it is disabled

Screen.Recording.2025-04-18.at.21.55.35.mov

src/pages/workspace/AccessOrNotFoundWrapper.tsx

…n-OD

eVoloshchak · 2025-04-27T14:59:50Z

src/pages/workspace/AccessOrNotFoundWrapper.tsx

-        setIsPolicyFeatureEnabled(isFeatureEnabled);
+
+        // When a workspace feature linked to the current page is disabled we will navigate to the More Features page.
+        Navigation.isNavigationReady().then(() => Navigation.goBack(ROUTES.WORKSPACE_MORE_FEATURES.getRoute(policyID)));


What is the purpose of using isNavigationReady here? Is there a scenario when the navigation isn't ready yet?

yes the scenario which caused the bug above on deep linking.

This doesn't look good, as the previous page flashes momentarily until navigation is ready

Screen.Recording.2025-04-29.at.21.34.16.mov

Could we show nothing (just the background) while navigation is not ready?

I think we are overcomplicating it @eVoloshchak because what we are trying to achieve in this pr is navigating away from pages linked to a non-existing feature so the flash is totally expected and this is not also a common use case by the way a user deeplinking to a disabled feature.

It still doesn't look right, previously it worked without any flashing (not found page was shown right away). Could we implement it so that the not found page would show initially until the navigation is ready?

@eVoloshchak previously we used to show not found page now what we are implementing is navigating away to more features and the above behavior is acceptable. Moreover, showing not found page until the navigation is ready doesn't help at all because we can see the previous page for an extremely small amount of duration, I think we are overthinking here.

@neil-marcellini WDYT about this. In my opinion, direct linking to a disabled feature is by itself very unlikely and if it happens what we are implementing in this pr is to navigate away to the more features page so the flashing is expected behavior.

Yeah I think that's acceptable. I don't even see it as much of a flash myself. Maybe there's a way it could be perfected, but let's not bother with it for such a rare edge case.

Thanks!
In that case, looks good to me, proceeding
@FitseTLT, could you resolve the conflicts please?

…n-OD

neil-marcellini · 2025-05-07T21:12:12Z

@eVoloshchak please lmk when you finish the PR reviewer checklist

eVoloshchak

LGTM!

OSBotify · 2025-05-08T16:17:04Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

FitseTLT added 3 commits April 2, 2025 01:44

navigate to more features on tax disabling

2c09110

replace with goBack

6525ee5

Merge branch 'main' into fix-showing-not-found-when-tax-is-disabled-i…

e6c2646

…n-OD

FitseTLT requested a review from a team as a code owner April 2, 2025 19:04

melvin-bot bot requested review from eVoloshchak and removed request for a team April 2, 2025 19:04

eVoloshchak suggested changes Apr 6, 2025

View reviewed changes

src/pages/workspace/AccessOrNotFoundWrapper.tsx Outdated Show resolved Hide resolved

eVoloshchak reviewed Apr 6, 2025

View reviewed changes

src/pages/workspace/AccessOrNotFoundWrapper.tsx Outdated Show resolved Hide resolved

FitseTLT added 2 commits April 7, 2025 14:40

Merge branch 'main' into fix-showing-not-found-when-tax-is-disabled-i…

72f3d0d

…n-OD

update comment

28e51d6

FitseTLT requested a review from eVoloshchak April 7, 2025 11:44

eVoloshchak reviewed Apr 9, 2025

View reviewed changes

src/pages/workspace/AccessOrNotFoundWrapper.tsx Outdated Show resolved Hide resolved

FitseTLT added 2 commits April 11, 2025 23:44

Merge branch 'main' into fix-showing-not-found-when-tax-is-disabled-i…

6b70649

…n-OD

apply it to all features

4523c69

FitseTLT requested a review from eVoloshchak April 11, 2025 20:51

eVoloshchak suggested changes Apr 16, 2025

View reviewed changes

eVoloshchak suggested changes Apr 18, 2025

View reviewed changes

eVoloshchak reviewed Apr 18, 2025

View reviewed changes

src/pages/workspace/AccessOrNotFoundWrapper.tsx Show resolved Hide resolved

FitseTLT added 4 commits April 24, 2025 00:06

Merge branch 'main' into fix-showing-not-found-when-tax-is-disabled-i…

276f183

…n-OD

fix lint

77076c3

minor fix

6134427

minor fix

1b00abe

FitseTLT requested a review from eVoloshchak April 23, 2025 21:25

eVoloshchak reviewed Apr 27, 2025

View reviewed changes

Merge branch 'main' into fix-showing-not-found-when-tax-is-disabled-i…

e699b64

…n-OD

FitseTLT requested a review from eVoloshchak May 7, 2025 17:11

neil-marcellini approved these changes May 7, 2025

View reviewed changes

eVoloshchak approved these changes May 8, 2025

View reviewed changes

melvin-bot bot requested a review from neil-marcellini May 8, 2025 08:55

neil-marcellini merged commit 28cb474 into Expensify:main May 8, 2025
16 of 17 checks passed

mountiny mentioned this pull request May 14, 2025

Deploy Checklist: New Expensify 2025-05-13 #61917

Closed

melvin-bot bot mentioned this pull request May 15, 2025

[Due for payment 2025-05-22] [$250] Tax backwards compatibility - After disable Tax in OD display an it's not here page in ND #59076

Closed

8 tasks

Fix - Tax backwards compatibility - After disable Tax in OD display an it's not here page in ND #59565

Fix - Tax backwards compatibility - After disable Tax in OD display an it's not here page in ND #59565

Uh oh!

Conversation

FitseTLT commented Apr 2, 2025

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Apr 2, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

eVoloshchak commented Apr 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

eVoloshchak left a comment

Choose a reason for hiding this comment

Uh oh!

FitseTLT commented Apr 16, 2025

Uh oh!

eVoloshchak left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

eVoloshchak Apr 27, 2025

Choose a reason for hiding this comment

Uh oh!

FitseTLT Apr 27, 2025

Choose a reason for hiding this comment

Uh oh!

eVoloshchak Apr 29, 2025

Choose a reason for hiding this comment

Uh oh!

FitseTLT Apr 29, 2025

Choose a reason for hiding this comment

Uh oh!

eVoloshchak May 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

FitseTLT May 6, 2025

Choose a reason for hiding this comment

Uh oh!

neil-marcellini May 6, 2025

Choose a reason for hiding this comment

Uh oh!

eVoloshchak May 7, 2025

Choose a reason for hiding this comment

Uh oh!

neil-marcellini commented May 7, 2025

Uh oh!

eVoloshchak left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented May 8, 2025

Uh oh!

Uh oh!

eVoloshchak commented Apr 15, 2025 •

edited

Loading

eVoloshchak May 4, 2025 •

edited

Loading