-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Expense - In offline, expense details page header & content is inconsistent with online behavior #61963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Triggered auto assignment to @thienlnam ( |
💬 A slack conversation has been started in #expensify-open-source |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
cc @neil-marcellini Do you happen to know where this might be coming from - is this from one of the report field changes you've been making? |
Could be #59568, it was deployed to staging with the current checklist (though it's not showing in the checklist 🤔) |
No I haven't touched report fields on the frontend. I feel like we have reported similar issues before, where the offline report title doesn't match the online one. |
We're planning to fix that inconsistency here Plan and implement a system for optimistic report title formula computation #59689 |
To confirm, once you get back online, is the report title correct? If so maybe let's not block on this, and keep it as a daily follow-up fix. |
@francoisl This is not a deploy blocker the behavior is the same on production only the fact that the PR only moved that report title settings from Rules > Reports section made them think it is a blocker 😄 |
Ah yes good point, just tested and confirmed the same behavior happens on production. |
@thienlnam but we should still fix it as a normal bug. |
Is this not something that will be fixed as part of #59689? |
I am not sure may be @neil-marcellini can suggest. |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.1.45-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
In online/offline, expense details page must show same content
Actual Result:
In offline, expense details page shows report title field as header and title field added in expense details page but expense details not shown. On turn online, expense details are shown
Workaround:
Unknown
Platforms:
Select the officially supported platforms where the issue was reproduced:
Platforms Tested:
On which of our officially supported platforms was this issue tested:Screenshots/Videos
Add any screenshot/video evidence
Bug6830232_1747171180068.Screenrecorder-2025-05-14-02-39-17-537.mp4
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: