Skip to content

Expense - In offline, expense details page header & content is inconsistent with online behavior #61963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 of 16 tasks
lanitochka17 opened this issue May 13, 2025 · 14 comments
Closed
3 of 16 tasks
Assignees

Comments

@lanitochka17
Copy link

lanitochka17 commented May 13, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.45-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Launch app
  2. Go to workspace settings - report
  3. Change default report title as {report:type} {🤔}
  4. Toggle on Prevent members from changing custom report names
  5. Enable report field
  6. Add a text field
  7. Go to workspace chat
  8. Turn off internet
  9. Create a manual expense
  10. Open the expense created
  11. Note header and contents of page
  12. Turn online
  13. Note header and contents of page

Expected Result:

In online/offline, expense details page must show same content

Actual Result:

In offline, expense details page shows report title field as header and title field added in expense details page but expense details not shown. On turn online, expense details are shown

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop
Platforms Tested: On which of our officially supported platforms was this issue tested:
  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6830232_1747171180068.Screenrecorder-2025-05-14-02-39-17-537.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label May 13, 2025
Copy link

melvin-bot bot commented May 13, 2025

Triggered auto assignment to @thienlnam (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented May 13, 2025

💬 A slack conversation has been started in #expensify-open-source

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@thienlnam
Copy link
Contributor

cc @neil-marcellini Do you happen to know where this might be coming from - is this from one of the report field changes you've been making?

@francoisl
Copy link
Contributor

Could be #59568, it was deployed to staging with the current checklist (though it's not showing in the checklist 🤔)

@neil-marcellini
Copy link
Contributor

No I haven't touched report fields on the frontend. I feel like we have reported similar issues before, where the offline report title doesn't match the online one.

@neil-marcellini
Copy link
Contributor

We're planning to fix that inconsistency here Plan and implement a system for optimistic report title formula computation #59689

@thienlnam
Copy link
Contributor

Oh yeah looks related - cc @FitseTLT / @blimpich Are you able to check this?

@francoisl
Copy link
Contributor

To confirm, once you get back online, is the report title correct? If so maybe let's not block on this, and keep it as a daily follow-up fix.

@FitseTLT
Copy link
Contributor

@francoisl This is not a deploy blocker the behavior is the same on production only the fact that the PR only moved that report title settings from Rules > Reports section made them think it is a blocker 😄

@francoisl
Copy link
Contributor

Ah yes good point, just tested and confirmed the same behavior happens on production.

@francoisl francoisl removed the DeployBlockerCash This issue or pull request should block deployment label May 14, 2025
@FitseTLT
Copy link
Contributor

@thienlnam but we should still fix it as a normal bug.

@thienlnam
Copy link
Contributor

Is this not something that will be fixed as part of #59689?

@FitseTLT
Copy link
Contributor

I am not sure may be @neil-marcellini can suggest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants