fix: Content before dot separator is empty #60192

daledah · 2025-04-14T16:22:37Z

Explanation of Change

Fixed Issues

$ #60087
PROPOSAL: #60087 (comment)

Tests

Create an expense
Go offline.
Right click on the expense preview > Delete expense.
Delete the expense.
Verify that: Expense deleted state (text with strikethrough) is shown, cursor display not-allowed.

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Screen.Recording.2025-05-08.at.23.05.11.mov

Android: mWeb Chrome

Screen.Recording.2025-05-08.at.23.05.55.mov

iOS: Native

Screen.Recording.2025-05-08.at.23.06.51.mov

iOS: mWeb Safari

Screen.Recording.2025-05-08.at.23.07.38.mov

MacOS: Chrome / Safari

Screen.Recording.2025-05-08.at.23.08.39.mp4

MacOS: Desktop

Screen.Recording.2025-05-08.at.23.09.21.mov

melvin-bot · 2025-04-14T17:44:54Z

@allgandalf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

allgandalf · 2025-04-15T04:28:30Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-04-15.at.10.24.26.AM.mov

Android: mWeb Chrome

Screen.Recording.2025-04-15.at.10.23.34.AM.mov

iOS: Native

Screen.Recording.2025-04-15.at.10.20.55.AM.mov

iOS: mWeb Safari

Screen.Recording.2025-04-15.at.10.20.22.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-04-15.at.10.17.48.AM.mov

MacOS: Desktop

Screen.Recording.2025-04-15.at.10.19.46.AM.mov

shawnborton · 2025-04-15T06:37:58Z

Similar comment I had in the other PR, why are we removing the big thumbnail placeholder upon delete? I would think that would stay in place, we just add the strikethrough style to the text:

allgandalf · 2025-04-15T06:40:20Z

@shawnborton i'm lost here now, weren't these solutions preApproved (on other PR's as well)?

#60087 (comment)

shawnborton · 2025-04-15T06:45:31Z

Looks like design wasn't tagged in that PR, so sorry for catching this one late!

mountiny · 2025-04-15T07:56:22Z

discussing the optimistic delete report preview look here #60104 (comment)

mountiny · 2025-04-15T08:02:36Z

From @shawnborton:

Yeah, my thinking is that we keep the general shape and styles, we just use strikethrough for any text that's visible in the report preview and expense previews. Basically this as a rough idea:

mountiny · 2025-04-15T08:03:43Z

This is for the report preview but for the expense preview the idea would be similar

@daledah would you be able to work on that for $250 bounty in the issue?

allgandalf · 2025-04-16T06:21:18Z

bump @daledah

daledah · 2025-04-16T07:05:00Z

This is for the report preview but for the expense preview the idea would be similar
@daledah would you be able to work on that for $250 bounty in the issue?

Yes, i can take a look

mountiny · 2025-04-16T12:25:46Z

Ping us in slack if you need anything, can you please prioritize this over new issues? thanks!

daledah · 2025-04-17T05:07:27Z

@mountiny I'll try to give an update today

mountiny · 2025-04-17T18:55:46Z

@daledah any luck?

daledah · 2025-04-17T19:06:26Z

@mountiny @allgandalf @shawnborton i updated, is this expected?

result.mp4

mountiny · 2025-04-17T19:24:46Z

I think in general yeas I am just not sure about the colour of the preview when its in the pending state cc @Expensify/design

daledah · 2025-05-08T16:19:27Z

@allgandalf Updated 👍

allgandalf · 2025-05-08T17:40:06Z

On my to-do list for tomorrow

allgandalf · 2025-05-09T05:57:05Z

@daledah I am still able to click on the expense and open it:

Screen.Recording.2025-05-09.at.11.25.42.AM.mov

Also jest is failing

allgandalf

Please look into ^

trjExpensify · 2025-05-09T10:41:04Z

@daledah did you address the comments? Is it ready for another review?

daledah · 2025-05-09T10:42:17Z

I'm checking now

daledah · 2025-05-09T11:04:46Z

@allgandalf I updated. I might've missed a style when merging main 😅

allgandalf

@shawnborton can you give approval from design perspective please , this LGTM!

trjExpensify · 2025-05-12T09:50:52Z

Can we see a video of it? I believe a couple of the recent bugs for us to confirm were:

The preview component was still clickable
The currency changed on deletion

github-actions · 2025-05-12T12:00:27Z

🚧 @mountiny has triggered a test app build. You can view the workflow run here.

mountiny · 2025-05-12T12:04:19Z

@daledah @allgandalf Could you provide that please?

mountiny · 2025-05-12T12:33:36Z

this is looking good to me, there is still no offline pattern on the table view, but I think that should be out of scope so we can wrap this one up
https://github.com/user-attachments/assets/fde702f4-a0e2-480d-b915-3c25706b78be

mountiny

Changes look good to me, just waiting for the final design confirmation

github-actions · 2025-05-12T12:43:16Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
Android 🤖🔄	iOS 🍎🔄
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/60192-hybrid/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/60192-hybrid/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/60192/NewExpensify.dmg	https://60192.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

trjExpensify · 2025-05-12T12:43:30Z

Mhm yeah, we should for'sure add the offline pattern to the table view. Who's going to take that follow-up?

mountiny · 2025-05-12T12:46:57Z

I think we should just create a new issue for SWM for that #60087 this pr already moved quite a bit from the original issue

shawnborton · 2025-05-12T16:05:22Z

All good on my end 👍

trjExpensify · 2025-05-12T16:46:03Z

I think we should just create a new issue for SWM for that #60087 this pr already moved quite a bit from the original issue

For the breadcrumbs: #61848

OSBotify · 2025-05-12T17:15:21Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-05-13T18:21:05Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.45-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

github-actions · 2025-05-13T19:31:30Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.45-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-05-15T19:00:01Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.1.45-21 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

daledah added 3 commits April 14, 2025 23:20

fix: Content before dot separator is empty

a9129f2

fix test

54007dc

fix jest test 3

2ff1b21

daledah marked this pull request as ready for review April 14, 2025 17:44

daledah requested a review from a team as a code owner April 14, 2025 17:44

melvin-bot bot requested review from allgandalf and removed request for a team April 14, 2025 17:44

allgandalf approved these changes Apr 15, 2025

View reviewed changes

melvin-bot bot requested a review from mountiny April 15, 2025 04:55

mountiny assigned allgandalf and daledah and unassigned allgandalf Apr 15, 2025

Merge branch 'main' into fix/60087

9f31abe

add the optimistic to delete money request

2b8c76d

fix ts error

07ab38e

Merge branch 'main' into fix/60087

a2ac4f5

allgandalf suggested changes May 9, 2025

View reviewed changes

Merge branch 'main' into fix/60087

335d091

daledah added 2 commits May 9, 2025 17:57

Merge branch 'main' into fix/60087

259fa42

fix: add missing styles

359450f

Merge branch 'main' into fix/60087

ac8b346

allgandalf approved these changes May 12, 2025

View reviewed changes

mountiny approved these changes May 12, 2025

View reviewed changes

mountiny mentioned this pull request May 12, 2025

[Better Expense Report Views] Add offline pattern for new expenses in the report table view #61848

Open

mountiny merged commit 205cfd6 into Expensify:main May 12, 2025
17 checks passed

github-actions bot mentioned this pull request May 13, 2025

Deploy Checklist: New Expensify 2025-05-13 #61917

Closed

fix: Content before dot separator is empty #60192

fix: Content before dot separator is empty #60192

Conversation

daledah commented Apr 14, 2025 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Apr 14, 2025

allgandalf commented Apr 15, 2025 • edited Loading

Reviewer Checklist

Screenshots/Videos

shawnborton commented Apr 15, 2025

allgandalf commented Apr 15, 2025

shawnborton commented Apr 15, 2025

mountiny commented Apr 15, 2025

mountiny commented Apr 15, 2025

mountiny commented Apr 15, 2025 • edited Loading

allgandalf commented Apr 16, 2025

daledah commented Apr 16, 2025

mountiny commented Apr 16, 2025

daledah commented Apr 17, 2025

mountiny commented Apr 17, 2025

daledah commented Apr 17, 2025

mountiny commented Apr 17, 2025

daledah commented May 8, 2025

allgandalf commented May 8, 2025

allgandalf commented May 9, 2025

allgandalf left a comment

Choose a reason for hiding this comment

trjExpensify commented May 9, 2025

daledah commented May 9, 2025

daledah commented May 9, 2025

allgandalf left a comment

Choose a reason for hiding this comment

trjExpensify commented May 12, 2025

github-actions bot commented May 12, 2025

mountiny commented May 12, 2025

mountiny commented May 12, 2025

mountiny left a comment

Choose a reason for hiding this comment

github-actions bot commented May 12, 2025

trjExpensify commented May 12, 2025

mountiny commented May 12, 2025

shawnborton commented May 12, 2025

trjExpensify commented May 12, 2025

OSBotify commented May 12, 2025

github-actions bot commented May 13, 2025

github-actions bot commented May 13, 2025

github-actions bot commented May 15, 2025

daledah commented Apr 14, 2025 •

edited

Loading

allgandalf commented Apr 15, 2025 •

edited

Loading

mountiny commented Apr 15, 2025 •

edited

Loading