[Better Expense Report View] Track expense - Content before dot separator is empty when track expense is deleted offline

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.27-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp #59811
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

• Log in with Expensifail account.
• Account has self DM.(please try Create an unreported expense on OD to trigger self DM in ND).

1. Go to staging.new.expensify.com
2. Go to self DM.
3. Track a manual expense in self DM.
4. Go offline.
5. Right click on the expense preview > Delete expense.
6. Delete the expense.

Expected Result:

The date in the expense preview will not disappear when track expense is deleted offline.

Actual Result:

The date in the expense preview disappears when track expense is deleted offline. This results in empty content before the dot separator in the expense preview.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6799008_1744339321508.20250411_103443.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @allgandalf

[melvin-bot]

Triggered auto assignment to @techievivek (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The date in the expense preview disappears when track expense is deleted offline. This results in empty content before the dot separator in the expense preview.

What is the root cause of that problem?

transaction in here is undefined, but isCreatedMissing still returns false

App/src/libs/TransactionUtils/index.ts

Lines 345 to 347 in bee2cb5

	function isCreatedMissing(transaction: OnyxEntry<Transaction>) {
	return transaction?.created === '' && (!transaction.created || transaction.modifiedCreated === '');
	}

It leads to unshift dotSeparator to previewHeaderText without date

App/src/libs/TransactionPreviewUtils.ts

Lines 193 to 197 in bee2cb5

	if (!isCreatedMissing(transaction)) {
	const created = getFormattedCreated(transaction);
	const date = DateUtils.formatWithUTCTimeZone(created, DateUtils.doesDateBelongToAPastYear(created) ? CONST.DATE.MONTH_DAY_YEAR_ABBR_FORMAT : CONST.DATE.MONTH_DAY_ABBR_FORMAT);
	previewHeaderText.unshift({text: date}, dotSeparator);
	}

What changes do you think we should make in order to solve the problem?

We should return true in function isCreatedMissing when we don't have transaction

function isCreatedMissing(transaction: OnyxEntry<Transaction>) {
    if (!transaction) {
        return true;
    }
    return transaction?.created === '' && (!transaction.created || transaction.modifiedCreated === '');
}

App/src/libs/TransactionUtils/index.ts

Lines 345 to 347 in bee2cb5

	function isCreatedMissing(transaction: OnyxEntry<Transaction>) {
	return transaction?.created === '' && (!transaction.created || transaction.modifiedCreated === '');
	}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[daledah]

@techievivek @RachCHopkins i can help to raise a quick PR if needed

[techievivek]

This seems related to the #59811?

[techievivek]

Should be safe to demote this as it's a very typical flow and needs deletion of expense in offline.

[Guccio163]

@daledah's solution seems OK, but I'd wait for @JakubKorytko's opinion, since he created this 👆

[JakubKorytko]

LGTM

[mountiny]

@daledah can you please raise a PR? Thanks!

[daledah]

I'll raise a PR in a few hours

[melvin-bot]

This issue has not been updated in over 15 days. @RachCHopkins, @mountiny, @allgandalf, @daledah eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[RachCHopkins]

Conversations are ongoing in PR thread.

[allgandalf]

Should get merged this week!