Skip to content

Deploy Checklist: New Expensify 2025-04-11 #60076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
33 tasks done
github-actions bot opened this issue Apr 11, 2025 · 11 comments
Closed
33 tasks done

Deploy Checklist: New Expensify 2025-04-11 #60076

github-actions bot opened this issue Apr 11, 2025 · 11 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Monthly KSv2 StagingDeployCash

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Apr 11, 2025

Release Version: 9.1.27-5
Compare Changes: production...staging

This release contains changes from the following pull requests:

Internal QA:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics for this release version and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked Firebase Crashlytics for the previous release version and verified that the release did not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@gleitebr gleitebr added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Apr 11, 2025
Copy link
Contributor Author

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/9.1.27-0 🚀

@m-natarajan
Copy link

#58825 -Checking it off this PR was deployed previous deploy

@izarutskaya
Copy link

Regression is 94% completed.

Blockers:
#60086
#60087
#60094

@mountiny
Copy link
Contributor

Tested #59712 and it worked 🎉

@m-natarajan
Copy link

m-natarajan commented Apr 11, 2025

Regression is 97% completed
#59862 - Pending validation in mWeb, Android and iOS,
#59811 - Is failing in web, Android and iOS because of #60084 (Repro in production- only in expensifail account) Checking it off

@m-natarajan
Copy link

Regression completed
#59862 - Checking this off as per this comment

Blockers:
#60086
#60087
#60094

@melvin-bot melvin-bot bot added the Monthly KSv2 label Apr 14, 2025
@mountiny
Copy link
Contributor

Checklist is clear, only waiting for confirmation of https://expensify.slack.com/archives/C9YU7BX5M/p1744631405452609 if its all good to check off

@mountiny
Copy link
Contributor

QAed #60203 in staging and it worked well! Checking off

@marcaaron
Copy link
Contributor

  • Checklist done.
  • App Timing Dashboard looks.. weird. But has been weird for over a month so assuming this is not a blocker.

Crashlytics stuff...

HybridApp

Current version: 9.1.27

iOS

Nothing new.

Android

Nothing new.

Previous version: 9.1.26

iOS

facebook::jsi::JSError around 5 crashes something related to an ImageLoader class.

BaseModalViewController.setupConstraintsForiPadIfNeeded() looks like a one off.

Android

JSCWrapper.confirmButtonClickCallback. I don't see ReviewAppModalController in the codebase. Quite confused about where this is coming from, but guessing we reverted it. There's one incidence so I'm not stressed about it.

@marcaaron
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Monthly KSv2 StagingDeployCash
Projects
None yet
Development

No branches or pull requests

6 participants