[CP Staging] Remove beta newDotHelpSidePanel, show help button only based on Onyx key
#60135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francoisl
force-pushed
the
francois-revert-59221
branch
from
e0535e4 to
6ab3907
Compare
|
@ Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
To add clarity: if you sign out and then sign back in, it's expected that the button won't appear anymore. The NVP is not persisted to the backend. |
Reviewer Checklist
Screenshots/VideosAndroid: Native60135_android_native.movAndroid: mWeb Chrome60135_android_web.moviOS: Native60135_ios_native.moviOS: mWeb Safari60135_ios_web.movMacOS: Chrome / Safari60135_web_chrome.movMacOS: Desktop60135_web_desktop.mov |
brunovjk
approved these changes
Apr 11, 2025
There was a problem hiding this comment.
LGTM. Just pay attention to this comment.
To open the console in others platforms, use this tutorial and/or the app's own "Debug console": Go to "Settings" > "Troubleshoot" > Enable "Client side logging" > Click "View debug console"
|
@arosiclair Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
chiragsalian
approved these changes
Apr 11, 2025
francoisl
changed the title
newDotHelpSidePanel, show help button only based on Onyx keynewDotHelpSidePanel, show help button only based on Onyx key
|
Was asked to review/merge early since we want to CP so took over the review. |
OSBotify
pushed a commit
that referenced
this pull request
Apr 11, 2025
[CP Staging] Remove beta `newDotHelpSidePanel`, show help button only based on Onyx key (cherry picked from commit a00349b) (CP triggered by francoisl)
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
33 tasks
|
🚀 Cherry-picked to staging by https://github.com/francoisl in version: 9.1.27-2-staging 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
github-actions
bot
added
the
DeployBlockerCash
Performance Comparison Report 📊 (1/3)Significant Changes To Duration
Show details
|
Performance Comparison Report 📊 (2/3)Meaningless Changes To Duration (1/2)Show entries
Show details
|
Performance Comparison Report 📊 (3/3)Meaningless Changes To Duration (2/2)Show entries
Show details
|
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
8 tasks
|
^ Sounds like a false positive, this PR just removes a beta and doesn't affect the search router. |
francoisl
removed
the
DeployBlockerCash
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.1.28-15 🚀
|
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation of Change
This removes the beta
newDotHelpSidePanel, and restores the logic to show the help side panel button to be only based on the Onyx keynvp_sidePanel, so that we can more easily test on any account by runningOnyx.set("nvp_sidePanel", {});in the JS console.Fixed Issues
$ #60069
https://expensify.slack.com/archives/C07NZ8B1VTQ/p1744318812379879?thread_ts=1743366781.999989&cid=C07NZ8B1VTQ
Tests
Onyx.set("nvp_sidePanel", {});Onyx.set("nvp_sidePanel", null);Offline tests
Same as tests
QA Steps
Same as test steps above
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
MacOS: Chrome / Safari
Screen.Recording.2025-04-11.at.10.25.47.mov