LHN - Archived WS chat for the removed member is not moved to the bottom of the LHN

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.27-3
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5928939
Issue reported by: Applause - Internal Team

Action Performed:

1. Navigate to the staging.new.expensify.com and sign in
2. Create a workspace and invite a member
3. Observe the LHN - new workspace chat was created for the invited user
4. Removed the member from the workspace
5. Check the LHN

Expected Result:

The workspace chat for the removed member is archived and put at the bottom of the LHN

Actual Result:

The workspace chat for the removed member is archived, but is not put at the bottom of the LHN. It remains in the same place with the "archived" status

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6801965_1744653057349.Recording__70.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @dangrous (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[dangrous]

Looks like this was caused by 3e18761 so #59962 - will see if I can figure out a quick fix, cc @tgolen @srikarparsi if you have any thoughts!

[samranahm]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Archived WS chat for the removed member is not moved to the bottom of the LHN

What is the root cause of that problem?

This happen because here we only check for isArchivedNonExpenseReport and just #rooms and other non expense chats go to bottom when archived

App/src/libs/SidebarUtils.ts

Lines 301 to 302 in 2003e28

	} else if (isArchivedNonExpenseReport(report, rNVPs)) {
	archivedReports.push(miniReport);

What changes do you think we should make in order to solve the problem?

we should add isArchivedReportWithID(report?.reportID)) here

App/src/libs/SidebarUtils.ts

Line 301 in 2003e28

} else if (isArchivedNonExpenseReport(report, rNVPs)) {

} else if (isArchivedNonExpenseReport(report, rNVPs) || isArchivedReportWithID(report?.reportID)) {
    archivedReports.push(miniReport);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[dangrous]

Seems like the issue is the rNVPs in this line are never loaded, always undefined. Will see if I can figure out why. If they're loaded properly, the code works.

[dangrous]

ah got it, need to use

const rNVPs = reportNameValuePairs?.[`${ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS}${report?.reportID}`];

not just

const rNVPs = reportNameValuePairs?.[report?.reportID];

Going to double check we don't need this change anywhere else