Skip to content

[Due for payment 2025-05-05] [Better Expense Report View] Split - No split preview in group chat in Expensifail accounts #60084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
6 of 8 tasks
mitarachim opened this issue Apr 11, 2025 · 14 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@mitarachim
Copy link

mitarachim commented Apr 11, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.27-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: #59811
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Log in with Expensfail account.
  1. Go to staging.new.expensify.com
  2. Open a group chat.
  3. Click + > Split expense > Manual.
  4. Split a manual expense.

Expected Result:

There will be a split preview in the group chat.

Actual Result:

There is no split preview in the group chat.

When sending a message after splitting expense in group chat, the message has no user name and avatar.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6798974_1744336011671.20250411_094457.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @johncschuster / @bfitzexpensify
@mitarachim mitarachim added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Apr 11, 2025
Copy link

melvin-bot bot commented Apr 11, 2025

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@bfitzexpensify
Copy link
Contributor

@JakubKorytko mind taking a look? This might be related to #59811

@bfitzexpensify
Copy link
Contributor

Bump @JakubKorytko

@bfitzexpensify
Copy link
Contributor

I'm heading OOO until April 29th. Adding a buddy:

Current status:

  • Looking for insight from Jakub on what might have caused this

@bfitzexpensify bfitzexpensify added Bug Something is broken. Auto assigns a BugZero manager. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Apr 16, 2025
Copy link

melvin-bot bot commented Apr 16, 2025

Current assignee @bfitzexpensify is eligible for the Bug assigner, not assigning anyone new.

@bfitzexpensify bfitzexpensify removed their assignment Apr 16, 2025
@bfitzexpensify bfitzexpensify added Bug Something is broken. Auto assigns a BugZero manager. and removed Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Apr 16, 2025
Copy link

melvin-bot bot commented Apr 16, 2025

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Daily KSv2 label Apr 16, 2025
@bfitzexpensify bfitzexpensify self-assigned this Apr 16, 2025
@JakubKorytko
Copy link
Contributor

JakubKorytko commented Apr 16, 2025

I will take a look today.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Apr 16, 2025
@mountiny mountiny self-assigned this Apr 16, 2025
@mountiny mountiny moved this to Second Cohort - CRITICAL in [#whatsnext] #migrate Apr 16, 2025
@mountiny mountiny changed the title Split - No split preview in group chat in Expensifail accounts [Better Expense Report View] Split - No split preview in group chat in Expensifail accounts Apr 16, 2025
@melvin-bot melvin-bot bot removed the Weekly KSv2 label Apr 28, 2025
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production labels Apr 28, 2025
@melvin-bot melvin-bot bot changed the title [Better Expense Report View] Split - No split preview in group chat in Expensifail accounts [Due for payment 2025-05-05] [Better Expense Report View] Split - No split preview in group chat in Expensifail accounts Apr 28, 2025
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Apr 28, 2025
Copy link

melvin-bot bot commented Apr 28, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Apr 28, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.32-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-05-05. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Apr 28, 2025

@mountiny @johncschuster / @bfitzexpensify @JakubKorytko The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@johncschuster
Copy link
Contributor

BugZero Checklist:

  • [Contributor] Classify the bug:
Bug classification

Source of bug:

  • 1a. Result of the original design (eg. a case wasn't considered)
  • 1b. Mistake during implementation
  • 1c. Backend bug
  • 1z. Other:

Where bug was reported:

  • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
  • 2b. Reported on staging (eg. found during regression or PR testing)
  • 2d. Reported on a PR
  • 2z. Other:

Who reported the bug:

  • 3a. Expensify user
  • 3b. Expensify employee
  • 3c. Contributor
  • 3d. QA
  • 3z. Other:
  • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

    Link to comment:

  • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

    Link to discussion:

  • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal Template
  • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

    Link to issue:

Regression Test Proposal

Precondition:

Test:

Do we agree 👍 or 👎

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels May 5, 2025
Copy link

melvin-bot bot commented May 5, 2025

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

@johncschuster
Copy link
Contributor

@DylanDylann, I see you reviewed the linked PR. Will you be paid for the entire "Better Reports" project, or does this issue require individual payment?

@mountiny
Copy link
Contributor

mountiny commented May 5, 2025

@johncschuster sorry for a late response, but the payments for the project will be handled in one go later. Same as regression testing so we can close this one. Thank you!

@mountiny mountiny closed this as completed May 5, 2025
@github-project-automation github-project-automation bot moved this from Second Cohort - CRITICAL to Done in [#whatsnext] #migrate May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
Development

No branches or pull requests

5 participants