[Better Expense Report View] Fix splits in group chats #60344

JakubKorytko · 2025-04-16T13:19:56Z

Explanation of Change

Considering that splits in group chat have no reportID and I found out that this is a desired outcome, I've fixed it so that split expenses in group chats are displayed as TransactionPreview (same as in self-DM).

App/src/libs/actions/IOU.ts

Lines 6129 to 6145 in 01c6daa

    
           // ReportID is -2 (aka "deleted") on the group transaction 
        
           const splitTransaction = buildOptimisticTransaction({ 
        
               transactionParams: { 
        
                   amount: 0, 
        
                   currency, 
        
                   reportID: CONST.REPORT.SPLIT_REPORTID, 
        
                   comment: parsedComment, 
        
                   merchant: CONST.TRANSACTION.PARTIAL_TRANSACTION_MERCHANT, 
        
                   receipt: receiptObject, 
        
                   category, 
        
                   tag, 
        
                   taxCode, 
        
                   taxAmount, 
        
                   billable, 
        
                   filename, 
        
               }, 
        
           });

Fixed Issues

$ #60084
PROPOSAL: N/A

Tests

Open any group chat
Send a split expense
Verify it displays properly

Offline tests

Same as tests

QA Steps

Same as tests

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

Web.mov

MacOS: Desktop

melvin-bot · 2025-04-16T17:24:59Z

@alitoshmatov Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

JakubKorytko · 2025-04-16T17:24:59Z

Note: There are several lint errors for newly added useOnyx rules that I would rather not touch in this PR, as it is not related to the issue.

mountiny · 2025-04-16T18:24:00Z

This is part of a project so I will let the C+ handle this

github-actions · 2025-04-16T18:24:45Z

🚧 @mountiny has triggered a test app build. You can view the workflow run here.

JakubKorytko · 2025-04-17T08:07:19Z

Note: There are several lint errors for newly added useOnyx rules that I would rather not touch in this PR, as it is not related to the issue.

I've changed all useOnyx calls to allow missing here to keep the logic as it was and to get rid of eslint errors.

mountiny · 2025-04-17T17:05:29Z

I've changed all useOnyx calls to allow missing here to keep the logic as it was and to get rid of eslint errors.

Did you confirm, though, it's expected that they can be missing here? we should not be just setting this to get rid of the ESLint error. We should thoroughly confirm this is expected

DylanDylann · 2025-04-18T07:37:00Z

This way is fine to solve the lint error

DylanDylann · 2025-04-18T07:37:07Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-04-18.at.14.51.46.mov

Android: mWeb Chrome

Screen.Recording.2025-04-18.at.14.41.39.mov

iOS: Native

Screen.Recording.2025-04-18.at.14.41.23.mov

iOS: mWeb Safari

Screen.Recording.2025-04-18.at.14.39.19.mov

MacOS: Chrome / Safari

Screen.Recording.2025-04-18.at.14.37.11.mov

MacOS: Desktop

Screen.Recording.2025-04-18.at.14.39.49.mov

DylanDylann

LGTM

JakubKorytko · 2025-04-18T09:44:34Z

Did you confirm, though, it's expected that they can be missing here? we should not be just setting this to get rid of the ESLint error. We should thoroughly confirm this is expected

Okay, I've checked useOnyx calls in this file and I believe only transaction is something always should be there.

App/src/components/ReportActionItem/TransactionPreview/index.tsx

Lines 38 to 48 in 92707c3

    
           const [iouReport] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${iouReportID}`); 
        
           const route = useRoute<PlatformStackRouteProp<TransactionDuplicateNavigatorParamList, typeof SCREENS.TRANSACTION_DUPLICATE.REVIEW>>(); 
        
           const [report] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${route.params?.threadReportID}`); 
        
           const isMoneyRequestAction = isMoneyRequestActionReportActionsUtils(action); 
        
           const transactionID = transactionIDFromProps ?? (isMoneyRequestAction ? getOriginalMessage(action)?.IOUTransactionID : null); 
        
           const [transaction] = useOnyx(`${ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`); 
        
           const violations = useTransactionViolations(transaction?.transactionID); 
        
           const [walletTerms] = useOnyx(ONYXKEYS.WALLET_TERMS); 
        
           const [session] = useOnyx(ONYXKEYS.SESSION); 
        
           const [chatReport] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${chatReportID}`); 
        
           const [personalDetails] = useOnyx(ONYXKEYS.PERSONAL_DETAILS_LIST);

walletTerms are not used at all, only checked if there are errors in it to display them
session is used for splits, not always the case
report, iouReport, chatReport - not always there, for example: self-DM - no IOU report, splits in group chats - no report, chatReport is for policy expense chat & workspace icon - not always the case as well
personalDetails - only for avatars in preview, same here, not always needed

I think due to TransactionPreview now being used not only in Report Preview but also in other places (like self-DMs & group chat splits) it is hard to make these variables required, I would just leave transaction as required and that also makes the most sense - since it is TransactionPreview, the rest is not that important, it should be handled in component ancestors to pass proper ID's.

mountiny

Design wise looks correct to me based on the design doc

src/pages/home/report/PureReportActionItem.tsx

github-actions · 2025-04-19T16:46:45Z

🚧 @mountiny has triggered a test app build. You can view the workflow run here.

github-actions · 2025-04-19T17:28:02Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
Android 🤖🔄	iOS 🍎🔄
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/60344-hybrid/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/60344-hybrid/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/60344/NewExpensify.dmg	https://60344.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

mountiny

Thanks!

OSBotify · 2025-04-22T09:33:47Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-04-23T18:45:09Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.32-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-04-28T19:52:02Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.1.32-8 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

JakubKorytko changed the title ~~[WIP] [Better Expense Report View] Fix splis in group chat~~ [WIP] [Better Expense Report View] Fix splits in group chats Apr 16, 2025

JakubKorytko force-pushed the korytko/fix-split-not-appearing-on-new-view branch from 1fe93b2 to 22f8768 Compare April 16, 2025 17:06

Display splits as separate expenses in group chat

e29a5b3

JakubKorytko force-pushed the korytko/fix-split-not-appearing-on-new-view branch from 22f8768 to e29a5b3 Compare April 16, 2025 17:08

JakubKorytko changed the title ~~[WIP] [Better Expense Report View] Fix splits in group chats~~ [Better Expense Report View] Fix splits in group chats Apr 16, 2025

JakubKorytko marked this pull request as ready for review April 16, 2025 17:24

JakubKorytko requested a review from a team as a code owner April 16, 2025 17:24

melvin-bot bot requested review from alitoshmatov and removed request for a team April 16, 2025 17:24

Merge branch 'main' into korytko/fix-split-not-appearing-on-new-view

a829ef2

mountiny assigned JakubKorytko Apr 16, 2025

mountiny removed the request for review from alitoshmatov April 16, 2025 18:23

This comment has been minimized.

Sign in to view

mountiny requested a review from DylanDylann April 16, 2025 19:04

JakubKorytko added 2 commits April 17, 2025 09:49

Merge branch 'main' into korytko/fix-split-not-appearing-on-new-view

b4c8e33

Make useOnyx optionals to keep the logic and fix eslint error

e968470

Merge branch 'main' into korytko/fix-split-not-appearing-on-new-view

84a5c24

DylanDylann approved these changes Apr 18, 2025

View reviewed changes

melvin-bot bot requested a review from mountiny April 18, 2025 07:42

Make transaction required in TransactionPreview

aef62e0

mountiny requested changes Apr 19, 2025

View reviewed changes

src/pages/home/report/PureReportActionItem.tsx Outdated Show resolved Hide resolved

src/pages/home/report/PureReportActionItem.tsx Show resolved Hide resolved

JakubKorytko added 2 commits April 22, 2025 08:02

Merge branch 'main' into korytko/fix-split-not-appearing-on-new-view

df3fb48

Reuse IOU requests type

2585ffd

JakubKorytko requested a review from mountiny April 22, 2025 06:32

mountiny approved these changes Apr 22, 2025

View reviewed changes

mountiny merged commit 8d9d43a into Expensify:main Apr 22, 2025
17 checks passed

github-actions bot mentioned this pull request Apr 23, 2025

Deploy Checklist: New Expensify 2025-04-23 #60729

Closed

91 tasks

melvin-bot bot mentioned this pull request Apr 28, 2025

[Due for payment 2025-05-05] [Better Expense Report View] Split - No split preview in group chat in Expensifail accounts #60084

Closed

8 tasks

	// ReportID is -2 (aka "deleted") on the group transaction
	const splitTransaction = buildOptimisticTransaction({
	transactionParams: {
	amount: 0,
	currency,
	reportID: CONST.REPORT.SPLIT_REPORTID,
	comment: parsedComment,
	merchant: CONST.TRANSACTION.PARTIAL_TRANSACTION_MERCHANT,
	receipt: receiptObject,
	category,
	tag,
	taxCode,
	taxAmount,
	billable,
	filename,
	},
	});

[Better Expense Report View] Fix splits in group chats #60344

[Better Expense Report View] Fix splits in group chats #60344

Uh oh!

Conversation

JakubKorytko commented Apr 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Apr 16, 2025

Uh oh!

JakubKorytko commented Apr 16, 2025

Uh oh!

mountiny commented Apr 16, 2025

Uh oh!

github-actions bot commented Apr 16, 2025

Uh oh!

This comment has been minimized.

JakubKorytko commented Apr 17, 2025

Uh oh!

mountiny commented Apr 17, 2025

Uh oh!

DylanDylann commented Apr 18, 2025

Uh oh!

DylanDylann commented Apr 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

DylanDylann left a comment

Choose a reason for hiding this comment

Uh oh!

JakubKorytko commented Apr 18, 2025

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Apr 19, 2025

Uh oh!

github-actions bot commented Apr 19, 2025

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Apr 22, 2025

Uh oh!

github-actions bot commented Apr 23, 2025

Uh oh!

github-actions bot commented Apr 28, 2025

Uh oh!

Uh oh!

JakubKorytko commented Apr 16, 2025 •

edited

Loading

DylanDylann commented Apr 18, 2025 •

edited

Loading