-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Company cards - Back button leads to wrong page instead of the Company cards page #60143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Triggered auto assignment to @isabelastisser ( |
Triggered auto assignment to @MonilBhavsar ( |
💬 A slack conversation has been started in #expensify-open-source |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
@isabelastisser FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors. |
Commented on the suspected PR |
🟢 I don't think this is a regression from our PR since it didn't not touch navigation logic, this seems more like Assign card step form flow related, which again our PR did not touch. I also think the way the Assign card step form works is expected, here's another example (that was present before our PR) where the Assign card step form jumps ahead, and when going back it goes back to previous steps (as expected): Screen.Recording.2025-04-11.at.13.11.28.mov♻ I guess we could implement something to where if we're on the "No active cards on this feed" in Assign card step form flow, we would simply dismiss the flow - but this wasn't mentioned anywhere in the other issue or during the PR and we've seen it as expected, therefore we did not touch the existing Assign card step form flow logic. |
Thanks for taking a look! @vincdargento could you please confirm if this is a blocker. Screen.Recording.2025-04-11.at.3.06.19.PM.mov |
Anyways, I'll demote as it is not worth a blocker |
@MonilBhavsar This is a video with both staging and prod. On prod, there is no ""No active cards on this feed" page bandicam.2025-04-11.15-29-04-742.mp4 |
♻ I think this should be closed as not a bug. Note the issue is only on staging because the PR was not deployed to production yet. |
Yeah fine closing it 👍 |
Yeah I'm okay with closing it - I agree we could add a specific case for that "No active cards on this feed" but I don't feel very strongly about it |
Thanks! yeah agree. If anyone thinks that we should handle this case, feel free to reopen |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Issue was found while executing QA for PR #59862
Version Number: 9.1.27-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #59862
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Samsung S23FE/ Android 14
App Component: Workspace Settings
Action Performed:
Precondition: Create 2 workspaces on a new Expensifail account.
Have the AMEX feed in the 2 workspaces and 2 cards assigned to the default user (admin) in one of the workspaces.
Steps:
Expected Result:
The back button leads to the Company cards page.
Actual Result:
The back button leads to the "Who needs a card assigned?" page instead of the Company cards page.
Workaround:
Unknown
Platforms:
Screenshots/Videos
bug.mp4
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: