Skip to content

[Report Creation UI] Workspace chat appears in search results for expense reports. #61915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
trjExpensify opened this issue May 13, 2025 · 8 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@trjExpensify
Copy link
Contributor

Coming from here.

Steps:

  1. Open Reports page
  2. Click on Expense Reports
  3. Click on Filter
  4. Click on From filter and select the person which you have access of expense chat (do yourself for easy repro)
  5. Click on View Results
  6. Observe the empty workspace chat appears in the results.
Image
@trjExpensify trjExpensify added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels May 13, 2025
@trjExpensify trjExpensify moved this to Second Cohort - CRITICAL in [#whatsnext] #migrate May 13, 2025
Copy link

melvin-bot bot commented May 13, 2025

Current assignee @trjExpensify is eligible for the Bug assigner, not assigning anyone new.

@trjExpensify
Copy link
Contributor Author

From @luacmartins in thread:

I think we can add a condition here to check for the type of report

if (isReportActionEntry(key)) {

@mountiny mountiny added the DeployBlockerCash This issue or pull request should block deployment label May 13, 2025
Copy link

melvin-bot bot commented May 13, 2025

Triggered auto assignment to @yuwenmemon (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented May 13, 2025

💬 A slack conversation has been started in #expensify-open-source

@mountiny
Copy link
Contributor

This PR wil lhide the empty reports behind the table report view beta so the workspace chat also is not visible but the root cause will still need to be fixed before the beta is removed #61967 @sumo-slonik

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels May 14, 2025
@luacmartins
Copy link
Contributor

Real fix here #61969

@francoisl francoisl removed the DeployBlockerCash This issue or pull request should block deployment label May 14, 2025
Copy link

melvin-bot bot commented May 14, 2025

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2
Projects
Status: Second Cohort - CRITICAL
Development

No branches or pull requests

8 participants