[$250] Android-Onboarding - Nothing happens after selecting unsupported integrations and tap Continue

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.45-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught during regression testing, add the test name, ID and link from TestRail: #60505
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Samsung Galaxy Z Fold 4 / Android 14
App Component: Other

Action Performed:

1. Launch Expensify app.
2. Log in with new Gmail account.
3. Select Manage my team's expenses.
4. Select 1-10 employees.
5. Select SAP.
6. Tap Continue.

Expected Result:

App will redirect to OD.

Actual Result:

Nothing happens after selecting unsupported integrations and tapping Continue.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6830037_1747160889962.Screen_Recording_20250514_022528_Expensify.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021922450287393061662
• Upwork Job ID: 1922450287393061662
• Last Price Increase: 2025-05-14

Issue Owner

Current Issue Owner: @allgandalf

[melvin-bot]

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @thienlnam (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[mitarachim]

not reproducible if we use Staging build and change Use Staging Server as ON after click in Join button.

2025-05-14.2.00.01.AM.mp4

[mitarachim]

QA team found different issue (The onboarding continues to the Concierge chat screen) in Desktop with below steps :

1. Sign up with gmail account
2. Manage my team expenses > Enter a company size within Micro (1–10) or Small (11–50).
3. On the integration selection screen, choose SAP, Oracle, Microsoft Dynamics, or Sage.
4. Proceed to the next step.

Bug6830125_1747164811683.Screen_Recording_2025-05-13_at_10.15.57_PM.mp4

it seems this issue have same root cause with 61932 , should we report as new GH issue ?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021922450287393061662

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allgandalf (External)

[rohit9625]

I think this issue happens on OldDot only as SAP accounting software option is not available for NewDot. Also could you please confirm if this happens when selecting Employee count as Small, i.e., 11-50, @mitarachim?

[mitarachim]

Hello @rohit9625 , we couldn't repro issue when selecting Employee count as Small, i.e., 11-50

2025-05-14.9.39.52.AM.mp4

2025-05-14.9.39.54.AM.mp4

[shubham1206agra]

Offending PR - #60505

cc @Ollyws @abzokhattab @chiragsalian

[rohit9625]

Oh, that's why I couldn't repro this issue on my end. That PR merged recently. However, by looking at the code in that PR and comparing it with the previous code I can see that some code is missing. Should I proceed with investigation or the PR author will take care of this?@shubham1206agra @mitarachim

[francoisl]

If we have the offending PR, let's go for a revert unless there's a very simple and 0-risk fix. There are already lot of deploy blockers at the moment, and potentially risking a fix that would cause further blockers will delay the next deploy even more.

I prepared a revert PR here - @chiragsalian or @thienlnam feel free to go ahead and merge if there's no easy fix proposed and I'm offline.

[rohit9625]

Well, I found the RCA of this issue and will create the proposal if prefer. It happens due this if condition:

App/src/pages/OnboardingAccounting/BaseOnboardingAccounting.tsx

Lines 226 to 232 in 23537ae

	const shouldRedirectToOldDot = getPlatform() !== CONST.PLATFORM.DESKTOP && (!isSupportedIntegration || onboardingCompanySize !== CONST.ONBOARDING_COMPANY_SIZE.MICRO);
	if (shouldRedirectToOldDot) {
	if (CONFIG.IS_HYBRID_APP) {
	return;
	}
	openOldDotLink(CONST.OLDDOT_URLS.INBOX, true);
	}

The isSupportedIntegration was false and resulting shouldRedirectToOldDot becomes true even it shouldn't be because previous condition was:

getPlatform() !== CONST.PLATFORM.DESKTOP && onboardingCompanySize !== CONST.ONBOARDING_COMPANY_SIZE.MICRO

And we returns from there if using Hybrid App. However, for NewDot the web browser is opened which wasn't the case prevously if selecting MICRO company size.

Also, here we are not calling COMPLETE_GUIDED_SETUP API if selected MICOR company size:

App/src/libs/actions/Report.ts

Lines 4078 to 4083 in 23537ae

	if (companySize && companySize !== CONST.ONBOARDING_COMPANY_SIZE.MICRO && getPlatform() !== CONST.PLATFORM.DESKTOP) {
	optimisticData.push({
	onyxMethod: Onyx.METHOD.MERGE,
	key: ONYXKEYS.NVP_ONBOARDING,
	value: {isLoading: true},
	});

However, the above code was there even before the offending PR. So, if this issue doesn't happens after reverting that PR then we can consider refactoring shouldRedirectToOldDot condition.

[shubham1206agra]

I can see multiple holes in the implementation. It's best to revert for now

[trjExpensify]

Build is running to CP the revert PR: #61989