-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[Due for payment 2025-05-27] Update onboarding page with new integration choices and redirection logic #60161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Job added to Upwork: https://www.upwork.com/jobs/~021911172188543432771 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws ( |
Triggered auto assignment to @sakluger ( |
|
Triggered auto assignment to Design team member for new feature review - @dannymcclain ( |
🚨 Edited by proposal-police: This proposal was edited at 2025-04-12 21:47:14 UTC. ProposalPlease re-state the problem that we are trying to solve in this issue.Update onboarding page with new integration choices and redirection logic What is the root cause of that problem?We need to:
What changes do you think we should make in order to solve the problem?
case CONST.POLICY.CONNECTIONS.NAME.SAP: {
text = translate('workspace.accounting.sap');
accountingIcon = Expensicons.SAPSquare;
break;
}
case CONST.POLICY.CONNECTIONS.NAME.ORACLE: {
text = translate('workspace.accounting.oracle');
accountingIcon = Expensicons.OracleSquare;
break;
}
case CONST.POLICY.CONNECTIONS.NAME.MS_DYNAMICS: {
text = translate('workspace.accounting.msDynamics');
accountingIcon = Expensicons.MicrosoftDynamicsSquare;
break;
}
case CONST.POLICY.CONNECTIONS.NAME.SAGE: {
text = translate('workspace.accounting.sage');
accountingIcon = Expensicons.SageSquare;
break;
}
case CONST.POLICY.CONNECTIONS.NAME.OTHER: {
text = translate('workspace.accounting.other');
accountingIcon = Expensicons.QuestionCircle;
break;
} also we need to add the new connections translation here
const shouldStayInNewDot = (
(onboardingCompanySize === ONBOARDING_COMPANY_SIZE.MICRO || onboardingCompanySize === ONBOARDING_COMPANY_SIZE.SMALL) && [
CONST.POLICY.CONNECTIONS.NAME.QBO,
CONST.POLICY.CONNECTIONS.NAME.QBD,
CONST.POLICY.CONNECTIONS.NAME.XERO,
CONST.POLICY.CONNECTIONS.NAME.NETSUITE,
CONST.POLICY.CONNECTIONS.NAME.OTHER,
null, // "None"
].includes(userReportedIntegration));
if (!shouldStayInNewDot ) {
openOldDotLink(CONST.OLDDOT_URLS.INBOX, true);
return;
}
}
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?NA What alternative solutions did you explore? (Optional)NA |
Swapping for Jon since he designed this—Jon feel free to toss back to me if you want, just want you to get that GitCoin credit lol |
Thanks Danny ❤️ Happy to take this one |
Friendly bump @Ollyws for initial contributor review. The priority on this issue is a bit urgent. |
@abzokhattab's proposal LGTM. |
Current assignee @chiragsalian is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new. |
Proposal LGTM, just one minor thing that i had to confirm internally. "Sage Intaact" already exists in the design and thats good, so we don't want to update/add "Sage" as an option. |
Hey @abzokhattab, what's the latest? And just to confirm, is this the PR: #60505? |
Triggered auto assignment to @miljakljajic ( |
I will be OOO from May 5 - 16, so I have added another BZ member to watch over the issue while I'm out. |
Correct, we are still working on it |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.46-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2025-05-27. 🎊 For reference, here are some details about the assignees on this issue:
|
@Ollyws @sakluger / @miljakljajic @Ollyws The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button] |
Part of the New Dot Onboarding for 1-50 Companies project
Main issue: https://github.com/Expensify/Expensify/issues/476894
Doc section: https://docs.google.com/document/d/1l1DytMDjRvEwJ7saOiZ3RZ4XjhPmR1kzOz90R0GmHVU/edit?tab=t.0#bookmark=id.b28s4buduv7a
Project: https://github.com/orgs/Expensify/projects/193/views/1
On HOLD till this is live - https://github.com/Expensify/Expensify/issues/490394. This can be worked on but can be merged only once the linked issue is done and its code is live.
Problem / Solution 1
We want to add more integration choices to our onboarding accounting page.

The integration choices we want to add areSAP, Oracle, Microsoft Dynamics, Sage, and Other

Problem / Solution 2
We want the styling to match this design

Problem / Solution 3
Note: i need to check if spanish translations are needed and to provide them.
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @Issue Owner
Current Issue Owner: @sakluger / @miljakljajicThe text was updated successfully, but these errors were encountered: