[Report Creation UI] Expense with violation shows View button on wide screen, Review button on small screen

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.45-4
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Search

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Submit an expense with violation (expense without category).
4. Go to Reports.
5. Go to Expense Reports.
6. Note that the expense row shows a View button.
7. Resize the screen to small.
8. Note that now the expense row shows a Review button (mweb, Android and iOS behavior).

Expected Result:

When an expense has violation, the expense row will show Review button in Expense Reports.

Actual Result:

On wide screen, when an expense has violation, the expense row shows View button.
On narrow screen, when an expense has violation, the expense row shows Review button.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6830391_1747185917286.20250514_092100.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @mollfpr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[trjExpensify]

I think this one might get fixed by @sumo-slonik's PR here to put the action button in the right place: #61903

Kuba, could you quickly test it?

[sumo-slonik]

I think this one might get fixed by @sumo-slonik's PR here to put the action button in the right place: #61903

Kuba, could you quickly test it?

Checking now

[sumo-slonik]

@trjExpensify
Here, the "review action" button that appears on the narrow layout is not the button in the transaction row, but the header button that used to appear in this spot for the narrow layout. In my PR, it was also added to the regular layout in the header:

heder action in normal view:

heder acion in narrow:

However, the change from "view" to "review" in the transaction row itself has not been fixed.

If you think this should be addressed as part of my PR, I can also investigate it.

[trjExpensify]

However, the change from "view" to "review" in the transaction row itself has not been fixed.

What is there to fix here? I think what you've just shown is correct.

From this issue OP we can see:

• No Review button at the header level (wide view) ❌
• Review button at the header level (narrow view) ✅

In your PR screenshots:

• Review button at the header level (wide view) ✅
• Review button at the header level (narrow view) ✅

So I think this one is solved by your PR. 👍

[sumo-slonik]

We have added a review button in the header, but for the transaction, there is still only a view button, not a review one. I thought we wanted to change this in this issue. If not, then this issue has been fixed in my PR.

Expected Result:
When an expense has violation, the expense row will show Review button in Expense Reports.

[trjExpensify]

Nah, that's just bad phrasing.

[trjExpensify]

We can close this, it was fixed in a PR for another issue.