Skip to content

[Report Creation UI] Total and action columns are not aligned and in the incorrect row #61895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
trjExpensify opened this issue May 13, 2025 · 19 comments
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@trjExpensify
Copy link
Contributor

Coming from here.

Image
  • The green View button should be on the header row in the Action column.
  • The bold total should be on the header row in the Total column.
  • Each expense on the report should have a hyperlinked view button in the Action column.

Example on staging:

Image
Copy link

melvin-bot bot commented May 13, 2025

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@sumo-slonik
Copy link
Contributor

Hi, I'm Kuba from SWM, and I'll take care of this

@mavrickdeveloper
Copy link

hey @sumo-slonik , didn't notice your message , i already addressed this

Copy link

melvin-bot bot commented May 13, 2025

📣 @mavrickdeveloper! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@sumo-slonik
Copy link
Contributor

Hi @mavrickdeveloper, where did you address it?

@mavrickdeveloper
Copy link

Here :

Expensify.61895.mp4

@mavrickdeveloper
Copy link

@trjExpensify any ideas why you are getting view button in different color than the current version of main branch ?

@Kicu
Copy link
Member

Kicu commented May 13, 2025

@mavrickdeveloper can you please provide an issue link and a PR link to help us better understand what specifically you are adressing and in what context?

Copy link

melvin-bot bot commented May 13, 2025

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@jliexpensify
Copy link
Contributor

@mavrickdeveloper you haven't been assigned this issue - if you haven't been assigned an issue, you're not able to work on it.

@trjExpensify
Copy link
Contributor Author

Sorry @jliexpensify forgot to add myself so you got assigned to BZ. Switching it! 👍

@jliexpensify
Copy link
Contributor

All good!

@trjExpensify
Copy link
Contributor Author

Marking this as a deploy blocker, so QA don't create more dupes like #61976

@trjExpensify trjExpensify added the DeployBlockerCash This issue or pull request should block deployment label May 14, 2025
Copy link

melvin-bot bot commented May 14, 2025

Triggered auto assignment to @srikarparsi (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented May 14, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels May 14, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented May 14, 2025

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@srikarparsi
Copy link
Contributor

This is being fixed in this PR

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels May 14, 2025
Copy link

melvin-bot bot commented May 14, 2025

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@luacmartins luacmartins self-assigned this May 14, 2025
@francoisl francoisl removed the DeployBlockerCash This issue or pull request should block deployment label May 14, 2025
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2
Projects
Status: Second Cohort - CRITICAL
Development

No branches or pull requests