-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[Better Expense Report Views] Split - Empty report preview appears in group member chat after splitting expense twice #61962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Triggered auto assignment to @tylerkaraszewski ( |
Triggered auto assignment to @flaviadefaria ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
💬 A slack conversation has been started in #expensify-open-source |
@flaviadefaria FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors. |
behind beta |
I'll take a look later. |
I'm not sure if this is actually a BERV problem. I found out that there is also a similar case in the old view:
Screen.Recording.2025-05-14.at.11.31.02.movI think it would be better to just not display this weird split below the preview at all (BERV & old view) by filtering |
The split report actions should only be in the parent chat where the split occured, so groupchats |
Just confirming it's possible to split in a 1:1 DM as well. 😄 |
Yeah yeah 🙄 |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.1.45-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Money Requests
Action Performed:
Precondition:
Expected Result:
There will be no empty report preview in 1:1 DM with the group member.
Actual Result:
There is an empty report preview in 1:1 DM with the group member.
Workaround:
Unknown
Platforms:
Screenshots/Videos
bug.mp4
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: