Skip to content

[Better Expense Report Views] Split - Empty report preview appears in group member chat after splitting expense twice #61962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
7 of 8 tasks
vincdargento opened this issue May 13, 2025 · 12 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@vincdargento
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.45-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Log in with Expensifail account.
  1. Go to staging.new.expensify.com
  2. Go to group chat with new users.
  3. Send a message if it is empty.
  4. Split a manual expense with group members.
  5. Go to Account > Troubleshoot.
  6. Click Clear cache and restart.
  7. Click Reset and refresh.
  8. Go to group chat.
  9. Split another manual expense.
  10. Open 1:1 DM with the group members.

Expected Result:

There will be no empty report preview in 1:1 DM with the group member.

Actual Result:

There is an empty report preview in 1:1 DM with the group member.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

@vincdargento vincdargento added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels May 13, 2025
Copy link

melvin-bot bot commented May 13, 2025

Triggered auto assignment to @tylerkaraszewski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented May 13, 2025

Triggered auto assignment to @flaviadefaria (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented May 13, 2025

💬 A slack conversation has been started in #expensify-open-source

@melvin-bot melvin-bot bot added Daily KSv2 and removed Hourly KSv2 labels May 13, 2025
@vincdargento
Copy link
Author

@flaviadefaria FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@mountiny mountiny removed the DeployBlockerCash This issue or pull request should block deployment label May 13, 2025
@mountiny mountiny moved this to Second Cohort - CRITICAL in [#whatsnext] #migrate May 13, 2025
@mountiny mountiny changed the title Split - Empty report preview appears in group member chat after splitting expense twice [Better Expense Report Views] Split - Empty report preview appears in group member chat after splitting expense twice May 13, 2025
@mountiny
Copy link
Contributor

behind beta

@JakubKorytko
Copy link
Contributor

I'll take a look later.

@JakubKorytko
Copy link
Contributor

JakubKorytko commented May 14, 2025

I'm not sure if this is actually a BERV problem. I found out that there is also a similar case in the old view:

  1. Create an split
  2. Clear cache
  3. Create another one
  4. Go to 1:1 DM
  5. There is a split inside the preview, as well as below it (the same as inside the preview). In Onyx, we can see a new Report Preview action with almost no data (not even the 'shouldShow' field is set).
  6. Clear the cache again.
  7. The split below the preview has disappeared, along with the Onyx entry.
Screen.Recording.2025-05-14.at.11.31.02.mov

I think it would be better to just not display this weird split below the preview at all (BERV & old view) by filtering shouldShow, which seems logical to me. However, I would need confirmation, @mountiny

@melvin-bot melvin-bot bot added Reviewing Has a PR in review and removed Daily KSv2 labels May 14, 2025
@melvin-bot melvin-bot bot added the Weekly KSv2 label May 14, 2025
@mountiny
Copy link
Contributor

The split report actions should only be in the parent chat where the split occured, so groupchats

@trjExpensify
Copy link
Contributor

The split report actions should only be in the parent chat where the split occured, so groupchats

Just confirming it's possible to split in a 1:1 DM as well. 😄

@trjExpensify trjExpensify moved this from Second Cohort - CRITICAL to Second Cohort - MEDIUM or LOW in [#whatsnext] #migrate May 15, 2025
@mountiny
Copy link
Contributor

Just confirming it's possible to split in a 1:1 DM as well. 😄

Yeah yeah 🙄

Copy link

melvin-bot bot commented May 16, 2025

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2
Projects
Status: Second Cohort - MEDIUM or LOW
Development

No branches or pull requests

7 participants